Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some use issue about WithArgs in namespace_opts.go #87

Open
Zheaoli opened this issue Mar 13, 2022 · 1 comment
Open

Some use issue about WithArgs in namespace_opts.go #87

Zheaoli opened this issue Mar 13, 2022 · 1 comment

Comments

@Zheaoli
Copy link
Member

Zheaoli commented Mar 13, 2022

Hello all,

I got some special issue about WithArgs in namespace_opts.go. For right now, the code below

func WithArgs(k, v string) NamespaceOpts {
	return func(c *Namespace) error {
		c.args[k] = v
		return nil
	}
}

Just allow people to use string as value when calling this function. But in the specification, the value may be a slice type. FYI https://www.cni.dev/docs/conventions/#args-in-network-config

I'm not sure if there is some mistake?

@Zheaoli
Copy link
Member Author

Zheaoli commented Mar 13, 2022

#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant