Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getwd: should we really hard fail? #3328

Closed
apostasie opened this issue Aug 18, 2024 · 0 comments · Fixed by #3329
Closed

getwd: should we really hard fail? #3328

apostasie opened this issue Aug 18, 2024 · 0 comments · Fixed by #3329
Labels
kind/unconfirmed-bug-claim Unconfirmed bug claim

Comments

@apostasie
Copy link
Contributor

Description

Investigating rootless-containers/usernetes#327

Current intuition is that the error comes from:
https://github.com/containerd/nerdctl/blob/main/pkg/rootlessutil/parent_linux.go#L87

Do we really need to hard-fail when we have no cwd?

Put otherwise: is it important that nsenter gets -w set no matter what (especially in the case where cwd does not exist), or can we just "not set" -w when getwd fails?

cc @AkihiroSuda

Steps to reproduce the issue

mkdir foo
cd foo
rmdir ../foo
nerdctl container run -d --name foo debian sleep Inf
FATA[0000] getwd: no such file or directory

Describe the results you received and expected

na

What version of nerdctl are you using?

main

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/unconfirmed-bug-claim Unconfirmed bug claim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant