Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check composefs compat when rebasing #632

Open
cgwalters opened this issue Jun 24, 2024 · 1 comment
Open

check composefs compat when rebasing #632

cgwalters opened this issue Jun 24, 2024 · 1 comment
Labels
area/cli Related to the client/CLI area/updates Related to upgrading between versions bug Something isn't working enhancement New feature or request triaged This looks like a valid issue

Comments

@cgwalters
Copy link
Collaborator

cgwalters commented Jun 24, 2024

Our default stance for bootc is to enable composefs, which requires sysroot.readonly=true, which in turn imposes other requirements/tweaks like ensuring the rootfs is mounted read-write in the initramfs with rw, etc.

It's a trap today if one is bootc switching from a system without this setup to a bootc base image that is, because we'll barf in the initramfs.

Short term, I think we can check at least before the update (and reboot) for this situation. Hmm, something we clearly should have more of but don't is static checks between the phases:

  • download new rootfs
  • <static checks>
  • queue bootloader entry

rpm-ostree at least does a bwrap invocation of true in the new root, which has verified some things in the past.

And the composefs one is pretty easy to check; look in the new root for /usr/lib/ostree/prepare-root.conf and check if it's enabled in the new one, but the current root doesn't have sysroot.readonly.

@cgwalters cgwalters added bug Something isn't working enhancement New feature or request area/updates Related to upgrading between versions triaged This looks like a valid issue area/cli Related to the client/CLI labels Jun 24, 2024
@cgwalters
Copy link
Collaborator Author

Also one thing people are starting to hit is ostreedev/ostree#3198 - we could definitely detect the case where one is using dynamic grub configs and the target is using composefs and at least error out for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to the client/CLI area/updates Related to upgrading between versions bug Something isn't working enhancement New feature or request triaged This looks like a valid issue
Projects
None yet
Development

No branches or pull requests

1 participant