Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop loopback out-of-process #799

Open
cgwalters opened this issue Sep 19, 2024 · 0 comments
Open

drop loopback out-of-process #799

cgwalters opened this issue Sep 19, 2024 · 0 comments
Labels
area/install Issues related to `bootc install` bug Something isn't working good first issue Good for newcomers

Comments

@cgwalters
Copy link
Collaborator

This one may be a good first issue: today when doing install --via-loopback, if we get killed by e.g. Ctrl-C (i.e. SIGINT) we will leak the loopback device allocation.

I've been thinking here what would be nice in general is to create a little "out of process drop" helper that could handle these external resources; it would:

  • mask most signals that would otherwise be fatal
  • own the resource and if the parent process died (via PR_SET_PDEATHSIG) we'd take care of dropping them

This type of flow would also be nice for temporary directories, which are also easy to leak in this way.


Hmm, we may also be able to stop forking /bin/losetup and instead use the ioctl APIs and only hold a file descriptor, but that's a bigger change.

@cgwalters cgwalters added bug Something isn't working good first issue Good for newcomers area/install Issues related to `bootc install` labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install` bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant