Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Drop upgrade --touch-if-changed #257

Merged
merged 1 commit into from
Jan 12, 2024
Merged

cli: Drop upgrade --touch-if-changed #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions lib/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ pub(crate) struct UpgradeOpts {
#[clap(long)]
pub(crate) quiet: bool,

#[clap(long)]
pub(crate) touch_if_changed: Option<Utf8PathBuf>,

/// Check if an update is available without applying it.
///
/// This only downloads an updated manifest and image configuration (i.e. typically kilobyte-sized metadata)
Expand Down Expand Up @@ -376,9 +373,6 @@ async fn upgrade(opts: UpgradeOpts) -> Result<()> {
}
}
if changed {
if let Some(path) = opts.touch_if_changed {
std::fs::write(&path, "").with_context(|| format!("Writing {path}"))?;
}
if opts.apply {
crate::reboot::reboot()?;
}
Expand Down
14 changes: 6 additions & 8 deletions manpages-md/bootc-upgrade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ bootc-upgrade - Download and queue an updated container image to apply

# SYNOPSIS

**bootc-upgrade** \[**\--quiet**\] \[**\--touch-if-changed**\]
\[**\--check**\] \[**\--apply**\] \[**-h**\|**\--help**\]
\[**-V**\|**\--version**\]
**bootc-upgrade** \[**\--quiet**\] \[**\--check**\] \[**\--apply**\]
\[**-h**\|**\--help**\] \[**-V**\|**\--version**\]

# DESCRIPTION

Expand All @@ -31,13 +30,12 @@ outside of a \`bootc upgrade \--apply\` do \*not\* upgrade.

: Dont display progress

**\--touch-if-changed**=*TOUCH_IF_CHANGED*

:

**\--check**

: Check if an update is available without applying it
: Check if an update is available without applying it.

This only downloads an updated manifest and image configuration (i.e.
typically kilobyte-sized metadata) as opposed to the image layers.

**\--apply**

Expand Down