Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Drop code/test uses of --security-opt #930

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

cgwalters
Copy link
Collaborator

We think this is unnecessary now; part of improving
the ergonomics of bootc install in general, but
especially with the to-existing-root path.

Once this lands, at some point later then we
can also remove it from all of the documentation.
But the most safe thing is to leave it in the
docs for a bit longer.

Closes: #928

@cgwalters
Copy link
Collaborator Author

Depends on #919

@github-actions github-actions bot added the area/install Issues related to `bootc install` label Dec 2, 2024
@cgwalters cgwalters force-pushed the tree-wide-security-opt branch from 6b62ba1 to bcdac01 Compare December 9, 2024 13:25
@cgwalters
Copy link
Collaborator Author

Rebased 🏄

@cgwalters cgwalters marked this pull request as ready for review December 9, 2024 13:26
@omertuc
Copy link
Contributor

omertuc commented Dec 10, 2024

Conflicts

We think this is unnecessary now; part of improving
the ergonomics of `bootc install` in general, but
especially with the `to-existing-root` path.

Once this lands, at some point later then we
can also remove it from all of the documentation.
But the most safe thing is to leave it in the
docs for a bit longer.

Closes: containers#928

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters force-pushed the tree-wide-security-opt branch from bcdac01 to fa474a9 Compare December 10, 2024 15:02
@cgwalters cgwalters enabled auto-merge December 10, 2024 19:34
@cgwalters cgwalters merged commit 3b58317 into containers:main Dec 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate dropping requirement for --security-opt label=type:unconfined_t
2 participants