-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support container-transports in --cache-to and --cache-from #4875
Comments
This is a nice feature request, I'll take it thanks. |
Ouch, while this is a nice feature request. I think this will break public API. I am working on a PR here, lets see if we can have consensus on this #4879 |
Why would it break public API? If it does, could always add another flag |
@penn5 By public api i mean the publicly exposed type |
Ah. I don't know Go, but my understanding is that there is not very much support for fancy types that could allow bypassing this. So either modifying the JSON deserializer to hackily deserialize as ImageReference, or making fields CacheFrom2 and CacheTo2. I would prefer the latter as the former still breaks the public API if we ever return these values, whereas with the latter we can just return a null CacheFrom and CacheTo meaning that consumers can parse the rest of the information without crashing, I hope. |
A friendly reminder that this issue had no activity for 30 days. |
Not at my end, I think flouthoc was gonna try to make a patch? |
A friendly reminder that this issue had no activity for 30 days. |
Description
There is no way to create a local cache without hosting a registry server on localhost and setting --cache-from/to=localhost/cache
Steps to reproduce the issue:
buildah build
Describe the results you received:
Describe the results you expected:
Buildah uses the provided path to cache images, allowing me to upload to CI cache coordinator.
Output of
rpm -q buildah
orapt list buildah
:Output of
buildah version
:Output of
cat /etc/*release
:Output of
uname -a
:Output of
cat /etc/containers/storage.conf
:not relevant but if you really care i'm just using the buildah:latest image,
podman run buildah cat /etc/containers/stroage.conf
will do itThe text was updated successfully, but these errors were encountered: