Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo Visibility Issue in GitHub Dark Theme #1791

Open
alexandear opened this issue Jan 8, 2024 · 2 comments
Open

Logo Visibility Issue in GitHub Dark Theme #1791

alexandear opened this issue Jan 8, 2024 · 2 comments
Assignees

Comments

@alexandear
Copy link
Contributor

It might seem minor, but I spotted the "containers" logo in the containers/.github repo that features black text on transparent backgrounds. Unfortunately, these don't display properly when I view the "containers" organization in GitHub's dark theme.

Screenshots

For instance, here's a screenshot to illustrate:

image

Compare the same screenshot but in the light theme:

image

Proposed solution

One of the solutions is to use separate logos for the Dark and Light theme. See https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/

@rhatdan
Copy link
Member

rhatdan commented Jan 9, 2024

@mairin WDYT?

@mairin mairin self-assigned this Jan 9, 2024
@mairin
Copy link
Member

mairin commented Jan 9, 2024

@rhatdan ill come up with a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants