build: Don't build cloned_binary as part of crun #1609
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building crun after commit 8a0ee4b yields the following link error:
This is because 8a0ee4b adds an include to "linux.h" (which has
get_bind_mount
and a transitive include to "error.h" which hascrun_error_release
). The Makefile forcrun
the binary buildssrc/libcrun/cloned_binary.c
... which is already built as part oflibcrun
the library which is linked directly tocrun
.Therefore it's enough to remove the
src/libcrun/cloned_binary.c
file fromcrun
sources, it is already included through the link step.An alternative would be to add src/libcrun/error.c, src/libcrun/utils.c, src/libcrun/linux.c to the crun sources, but that would be too much unnecessary bloat.