From f28468fa31af6cd99b5fefd8c442c91ee46d4323 Mon Sep 17 00:00:00 2001
From: Krisztian Litkey <krisztian.litkey@intel.com>
Date: Fri, 20 Sep 2024 09:23:45 +0300
Subject: [PATCH] build: verify buildability of binaries in CI.

Add missing verification of binary builds. Run verifications
in CI one at a time for more granular error reports. Update
the collective verify build target to run all verifications
in a single go.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
---
 .github/workflows/project-checks.yaml | 26 ++++++++++++++++++--------
 Makefile                              |  6 +++++-
 2 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/project-checks.yaml b/.github/workflows/project-checks.yaml
index 659bbd1b1..666df0a01 100644
--- a/.github/workflows/project-checks.yaml
+++ b/.github/workflows/project-checks.yaml
@@ -20,28 +20,38 @@ jobs:
     runs-on: ubuntu-22.04
     timeout-minutes: 5
     steps:
-      - uses: actions/checkout@v4
+      - name: Check out repository
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: actions/setup-go@v5
+
+      - name: Install golang toolchain
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
 
-      - name: make verify
+      - name: Verify dependencies
+        run: |
+          make verify-godeps
+
+      - name: Verify formatting
+        run: |
+          make verify-fmt
+
+      - name: Verify generated assets
         run: |
-          make verify
+          make verify-generate
 
-      - name: Build docs
+      - name: Verify binary builds
         run: |
-          make site-build
-          make clean-html
+          make verify-build
 
       - name: Install gh-pages build dependencies
         run: |
           pip3 install --user -r docs/requirements.txt
           echo "`python3 -m site --user-base`/bin" >> $GITHUB_PATH
 
-      - name: Verify update of gh-pages
+      - name: Verify documentation / update of gh-pages
         run: |
           git config user.name "Github"
           git config user.email "no-reply@github.com"
diff --git a/Makefile b/Makefile
index a78d791d3..e862e01fe 100644
--- a/Makefile
+++ b/Makefile
@@ -130,7 +130,7 @@ allclean: clean clean-cache
 
 test: test-gopkgs
 
-verify: verify-godeps verify-fmt verify-generate
+verify: verify-godeps verify-fmt verify-generate verify-build verify-docs
 
 #
 # build targets
@@ -397,6 +397,10 @@ verify-generate: generate
 	    exit "$$ec"; \
 	fi
 
+verify-build: build
+
+verify-docs: site-build clean-html
+
 #
 # targets for installing dependencies
 #