Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support images with both tag and digest #101

Open
akostadinov opened this issue Sep 5, 2024 · 5 comments
Open

Support images with both tag and digest #101

akostadinov opened this issue Sep 5, 2024 · 5 comments
Labels
blocked Waiting on something else to resolve bug Something isn't working

Comments

@akostadinov
Copy link

Hello, it seems like podman supports specifying both - tag and digest at the same time. See containers/common#579

So I guess podlet should do too.

@k9withabone
Copy link
Member

I'm guessing you are asking about this for a compose file. While Podman does support specifying both a tag and digest, the Compose Specification shows that it must be one or the other, not both.

@k9withabone k9withabone closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2024
@akostadinov
Copy link
Author

Nobody produces podman composes. You can only find docker composes in the wild. Ignoring this does not help the user.

@k9withabone
Copy link
Member

I'm not ignoring this. Did you read my reply? Did you see the link? The Compose Specification is primarily made by Docker for Docker and is what docker compose v2 is based on. If you think it should be changed with regard to specifying an image, you should create an issue there.

@akostadinov
Copy link
Author

akostadinov commented Oct 21, 2024

Ok, I thought it was related to podman. I don't think it has to be changed. Also I don't think it has to not be changed. It's just that I want composes I come across to work with minimal to no interventions 👼

I see that specifying both is accepted by docker though. Whether they intentionally or not write a spec they don't follow is a different topic. Example https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml

I think it makes sense and is straightforward to support. It has usefulness I assume to specify both so that one can figure out what image is being tracked by the compose author.

@k9withabone
Copy link
Member

Fair enough. I'll reopen this, but it will probably be a bit until it's resolved as it requires making breaking changes to my compose_spec library and I just released a new major version last week.

@k9withabone k9withabone reopened this Oct 23, 2024
@k9withabone k9withabone changed the title services.redis.image: image cannot have a tag and a digest at line 54 column 12 Support images with both tag and digest Oct 23, 2024
@k9withabone k9withabone added bug Something isn't working blocked Waiting on something else to resolve labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on something else to resolve bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants