Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting compose file fails when image registry url has a port #91

Closed
vaahtokarkki opened this issue Jul 1, 2024 · 3 comments · Fixed by #122
Closed

Converting compose file fails when image registry url has a port #91

vaahtokarkki opened this issue Jul 1, 2024 · 3 comments · Fixed by #122
Labels
bug Something isn't working
Milestone

Comments

@vaahtokarkki
Copy link

Podlet fails to parse image from compose file when the image registry url has a port defined. Reproducible with following steps;

  • Create compose.yaml with following contents:
services:
  test:
    image: ghcr.io:443/containers/podlet
  • Run podlet:
podman run --rm -v ./compose.yaml:/compose.yaml:Z ghcr.io/containers/podlet compose /compose.yaml

Following error is printed:

Error:
   0: error converting compose file
   1: error reading compose file
   2: File `/compose.yaml` is not a valid compose file
   3: services.test.image: invalid image tag: image tag contains invalid character '/', tags must only contain ASCII letters (a-z, A-Z), digits (0-9), dots (.), underscores (_), and dashes (-) at line 3 column 12
@nhi-vanye
Copy link

Also getting hit by this.

@k9withabone k9withabone added bug Something isn't working blocked Waiting on something else to resolve labels Sep 14, 2024
@k9withabone k9withabone added this to the v0.3.1 milestone Sep 14, 2024
@k9withabone
Copy link
Member

Good catch. I didn't think about registry ports when writing the image Name validation logic as it's not included in the regex of the spec and the "Implementers Note" wasn't there.

@k9withabone
Copy link
Member

Blocked on k9withabone/compose_spec_rs#22.

@k9withabone k9withabone removed the blocked Waiting on something else to resolve label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants