From 570a845658358e48b0bd1aca1a8405ba49b48ca0 Mon Sep 17 00:00:00 2001 From: Charlie Drage Date: Wed, 20 Mar 2024 10:03:48 -0400 Subject: [PATCH] chore: remove vfkit (#206) ### What does this PR do? Removes vfkit, functionality has been unused. ### Screenshot / video of UI N/A ### What issues does this PR fix or reference? N/A ### How to test this PR? N/A Signed-off-by: Charlie Drage --- packages/backend/src/extension.ts | 4 - packages/backend/src/launch-vfkit.ts | 105 --------------------------- 2 files changed, 109 deletions(-) delete mode 100644 packages/backend/src/launch-vfkit.ts diff --git a/packages/backend/src/extension.ts b/packages/backend/src/extension.ts index dfd5f04d..17e4616e 100644 --- a/packages/backend/src/extension.ts +++ b/packages/backend/src/extension.ts @@ -18,7 +18,6 @@ import type { ExtensionContext } from '@podman-desktop/api'; import * as extensionApi from '@podman-desktop/api'; -import { launchVFKit } from './launch-vfkit'; import { buildDiskImage } from './build-disk-image'; import { History } from './history'; import fs from 'node:fs'; @@ -34,9 +33,6 @@ export async function activate(extensionContext: ExtensionContext): Promise { - await launchVFKit(container); - }), extensionApi.commands.registerCommand('bootc.image.build', async image => { const selections = await bootcBuildOptionSelection(history); if (selections) { diff --git a/packages/backend/src/launch-vfkit.ts b/packages/backend/src/launch-vfkit.ts deleted file mode 100644 index 21191a92..00000000 --- a/packages/backend/src/launch-vfkit.ts +++ /dev/null @@ -1,105 +0,0 @@ -/********************************************************************** - * Copyright (C) 2024 Red Hat, Inc. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * - * SPDX-License-Identifier: Apache-2.0 - ***********************************************************************/ - -import * as extensionApi from '@podman-desktop/api'; -import * as fs from 'node:fs'; - -const telemetryLogger = extensionApi.env.createTelemetryLogger(); - -// eslint-disable-next-line @typescript-eslint/no-explicit-any -export async function launchVFKit(container: any): Promise { - const imageLocation = container.labels['bootc.build.image.location']; - - // Check that vfkit is installed and error if it isn't before executing - // eslint-disable-next-line @typescript-eslint/no-explicit-any - const telemetryData: Record = {}; - telemetryData.imageType = container.labels['bootc.build.type']; - try { - await extensionApi.process.exec('vfkit', ['--version']); - } catch (error) { - await extensionApi.window.showErrorMessage(`Unable to launch ${imageLocation} with vfkit: ${error}`); - telemetryData.error = 'no-version'; - telemetryLogger.logUsage('launchVfkit', telemetryData); - return; - } - - // Check to see if imageLocation exists and error if it doesn't before executing - if (!fs.existsSync(imageLocation)) { - await extensionApi.window.showErrorMessage( - `Unable to launch ${imageLocation} with vfkit: ${imageLocation} does not exist`, - ); - telemetryData.error = 'no-image'; - telemetryLogger.logUsage('launchVfkit', telemetryData); - return; - } - - // Check container.labels['bootc.build.type'] to see if it is ami or raw - // if it is not raw or ami, we cannot launch with vfkit - if (container.labels['bootc.build.type'] !== 'ami' && container.labels['bootc.build.type'] !== 'raw') { - await extensionApi.window.showErrorMessage( - `Unable to launch ${imageLocation} with vfkit: ${container.labels['bootc.build.type']} is not supported`, - ); - telemetryData.error = 'unsupported-type'; - telemetryLogger.logUsage('launchVfkit', telemetryData); - return; - } - - await launchVfkit(imageLocation, telemetryData); -} - -// eslint-disable-next-line @typescript-eslint/no-explicit-any -async function launchVfkit(imagePath: string, telemetryData: Record): Promise { - // take image path replace last part (disk.qcow2 / disk.raw) with vfkit-serial.log - // this will be the log file path - const logFilePath = imagePath.replace(/[^/]+$/, '') + 'vfkit-serial.log'; - const command = 'vfkit'; - const args = [ - '--cpus', - '2', - '--memory', - '2048', - '--bootloader', - 'efi,variable-store=./efi-variable-store,create', - '--device', - 'virtio-blk,path=' + imagePath, - '--device', - 'virtio-serial,logFilePath=' + logFilePath, - '--device', - 'virtio-net,nat,mac=72:20:43:d4:38:62', - '--device', - 'virtio-rng', - '--device', - 'virtio-input,keyboard', - '--device', - 'virtio-input,pointing', - '--device', - 'virtio-gpu,width=1920,height=1080', - '--gui', - ]; - console.log(args); - try { - await extensionApi.process.exec(command, args); - telemetryData.success = true; - telemetryLogger.logUsage('launchVfkit', telemetryData); - } catch (error) { - console.error(error); - telemetryData.error = error; - telemetryLogger.logUsage('launchVfkit', telemetryData); - await extensionApi.window.showErrorMessage(`Unable to launch ${imagePath} with vfkit: ${error}`); - } -}