Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log button for builds on dashboard. #677

Closed
cdrage opened this issue Jul 26, 2024 · 2 comments · Fixed by #792
Closed

Add log button for builds on dashboard. #677

cdrage opened this issue Jul 26, 2024 · 2 comments · Fixed by #792
Assignees
@cdrage
Labels
kind/feature 💡 Issue for requesting a new feature

Comments

@cdrage
Copy link
Contributor

cdrage commented Jul 26, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe

We should have a log button next to the delete button that loads up logs / essentially loads up with auto-refreshing the image log file (if it's available).

Multiple users have brought up "this doesn't work", but we have to explain to retrieve the image log file, it should be more accessible.

I encountered this a lot during implementing #623 where having a direct button to logs would of been handy.

It should:

  • Check that the log file exists
  • Loads it
  • Auto-refreshes

Describe the solution you'd like

Log button that loads up image log (in a terminal?).

Describe alternatives you've considered

No response

Additional context

No response
@cdrage cdrage added the kind/feature 💡 Issue for requesting a new feature label Jul 26, 2024
@cdrage cdrage self-assigned this Jul 26, 2024
@cdrage cdrage moved this to 📋 Backlog in Podman Desktop Planning Jul 26, 2024
@benoitf
Copy link
Contributor

benoitf commented Jul 26, 2024

hi, I'm not sure about which screen and which delete button you're referencing ?

@cdrage
Copy link
Contributor Author

cdrage commented Jul 26, 2024 •
edited
Loading

hi, I'm not sure about which screen and which delete button you're referencing ?

On the dashboard we have the delete button beside any builds.

We should have a log button beside it so it's more easily accessible / shows the current log of the build.

I've updated the title to reflect it, I worded it wrong. Apologizes!

@cdrage cdrage changed the title Add log button that loads image log Add log button that loads build log Jul 26, 2024
@cdrage cdrage changed the title Add log button that loads build log Add log button for builds on dashboard. Jul 26, 2024
@cdrage cdrage mentioned this issue Aug 1, 2024
Open
@cdrage cdrage moved this from 📋 Backlog to 🚧 In Progress in Podman Desktop Planning Sep 4, 2024
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 5, 2024
@cdrage
feat: adds log page for builds
be1340f 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 5, 2024
@cdrage
feat: adds log page for builds
cc21bd9 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage mentioned this issue Sep 5, 2024
Merged
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 5, 2024
@cdrage
feat: adds log page for builds
7db9018 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 5, 2024
@cdrage
feat: adds log page for builds
bc29815 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 5, 2024
@cdrage
feat: adds log page for builds
803efc7 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 5, 2024
@cdrage
feat: adds log page for builds
095f5d4 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage moved this from 🚧 In Progress to 🚥 In Review in Podman Desktop Planning Sep 6, 2024
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 11, 2024
@cdrage
feat: adds log page for builds
22944a9 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit that referenced this issue Sep 11, 2024
@cdrage
feat: adds log page for builds (#792)
096be24 
* feat: adds log page for builds

### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes #677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>

* update based on review

Signed-off-by: Charlie Drage <[email protected]>

---------

Signed-off-by: Charlie Drage <[email protected]>
@github-project-automation github-project-automation bot moved this from 🚥 In Review to ✔️ Done in Podman Desktop Planning Sep 11, 2024
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 11, 2024
@cdrage
feat: adds log page for builds
3ff583a 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 24, 2024
@cdrage
feat: adds log page for builds
4c2cf95 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Sep 27, 2024
@cdrage
feat: adds log page for builds
70948e6 
### What does this PR do?

* Adds a log action button that will show the logs in real-time in a
  separate page
* Automatically refreshes / appends to the output
* Uses terminal settings from Podman Desktop to match what the user has
  setup.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#677

### How to test this PR?

1. Start a build
2. Click the "logs" button on the dashboard
3. Watch logs propagate

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
kind/feature 💡 Issue for requesting a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adds log page for builds cdrage/podman-desktop-extension-bootc
2 participants
@benoitf @cdrage