Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Disk Image details page #856

Closed
deboer-tim opened this issue Sep 25, 2024 · 0 comments · Fixed by #866
Closed

Add a Disk Image details page #856

deboer-tim opened this issue Sep 25, 2024 · 0 comments · Fixed by #866
Assignees
@deboer-tim
Labels
kind/enhancement ✨ Issue for requesting an improvement
Milestone
1.5

Comments

@deboer-tim
Copy link
Contributor

Is your enhancement related to a problem? Please describe

Bootable containers don't have a details page.

Describe the solution you'd like

We should add a details page for each bootable container:

  • More consistent with Podman Desktop's patterns
  • A place to put additional information (don't need to add columns to the table for everything)
  • Future place to add terminal window in support of features like Ability to test an image localy #752.
  • We're already doing it for the build logs; will fit in better.

Describe alternatives you've considered

No response

Additional context

No response
@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Sep 25, 2024
@deboer-tim deboer-tim added this to the 1.5 milestone Sep 26, 2024
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Sep 27, 2024
@deboer-tim
feat: details page for disk images
7b5327e 
Modifies the build logs to have a proper details page for disk images, similar
to how Podman Desktop handles Images or Containers.

The two tabs are Summary and Build Logs. The summary page is simple for now
but could be expanded; the build logs doesn't really match what we typically
have in Podman Desktop, but it fits in better here than a standalone page.

Fixes podman-desktop#856.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim mentioned this issue Sep 27, 2024
Merged
@deboer-tim deboer-tim changed the title Add a Details page Add a Disk Image details page Sep 27, 2024
@deboer-tim deboer-tim self-assigned this Sep 27, 2024
@deboer-tim deboer-tim moved this to 🚥 In Review in Podman Desktop Planning Sep 27, 2024
@cdrage cdrage closed this as completed in 7b17a94 Sep 30, 2024
@github-project-automation github-project-automation bot moved this from 🚥 In Review to ✔️ Done in Podman Desktop Planning Sep 30, 2024
@deboer-tim deboer-tim mentioned this issue Sep 30, 2024
Closed
This was referenced Oct 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
kind/enhancement ✨ Issue for requesting an improvement
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

feat: details page for disk images deboer-tim/podman-desktop-extension-bootc
1 participant
@deboer-tim