New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments from PR #518 #526

Open

dougsland opened this issue Aug 31, 2024 · 2 comments

Assignees

Labels

jira Priority: low

Collaborator

dougsland commented Aug 31, 2024 •

edited

Loading

Author: dougsland
File Path: tests/e2e/lib/diskutils
Created At: 2024-08-31T11:49:58Z
Comment: looks like out of indent
View in GitHub

Author: dougsland
File Path: tests/e2e/lib/diskutils
Created At: 2024-08-31T11:51:06Z
Comment: if_error_exit?
View in GitHub

Author: dougsland
File Path: tests/e2e/lib/diskutils
Created At: 2024-08-31T11:51:44Z
Comment: if_error_exit? if not, better comment.
View in GitHub

Author: dougsland
File Path: tests/e2e/lib/diskutils
Created At: 2024-08-31T11:52:16Z
Comment: if_error_exit? or just warning? or just echo before ?
View in GitHub

Author: dougsland
File Path: tests/e2e/set-ffi-env-e2e
Created At: 2024-08-31T11:52:45Z
Comment: if_error_exit?
View in GitHub

dougsland added jira Priority: low labels

dougsland assigned Yarboa

Collaborator

Yarboa commented Sep 1, 2024

@dougsland instead of dealing with errors line by line
is it wiser to use set -eou for the bash command?

Collaborator Author

dougsland commented Sep 1, 2024

@dougsland instead of dealing with errors line by line is it wiser to use set -eou for the bash command?

whatever you feel more comfortable. I prefer one by one, it's less verbose but it's up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment