Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors trying to build a ramalama fedora image #594

Closed
maxamillion opened this issue Jan 16, 2025 · 5 comments
Closed

Compilation errors trying to build a ramalama fedora image #594

maxamillion opened this issue Jan 16, 2025 · 5 comments

Comments

@maxamillion
Copy link
Collaborator

hello all! I'm trying to build a ramalama container based on Fedora and using the Fedora ROCm libraries because those enable more gfx series of the APUs than the official ROCm packages (including one I happen to own and am wanting to test on)... however I'm getting a compilation error on something C/C++ that I lack the expertise to sort out and I was hoping someone might be able to help

I have my changes here: https://github.com/containers/ramalama/compare/main...maxamillion:ramalama:fedora-rocm?expand=1

build log here: https://maxamillion.fedorapeople.org/ramalama-build-out.txt

Thank you!

@ericcurtin
Copy link
Collaborator

Thanks for looking at this @maxamillion please open the failing PR with that change.

With copilot you can actually click a button to ask to diagnose the failing CI build, sometimes that saves a minute or two of a human parsing the issue!

@ericcurtin
Copy link
Collaborator

ericcurtin commented Jan 16, 2025

First of all you'll need this to be executed, it's not in your example Containerfile:

    rocm)
      common_flags+=("-DGGML_HIPBLAS=1")
      ;;

this currently is not building a ROCm based version of llama.cpp.

You can run the ubi9 image on Fedora for rocm.

But we can build a Fedora based version no biggie. But I would highly recommend comparing against how the UBI9 rocm image is built.

@ericcurtin
Copy link
Collaborator

ericcurtin commented Jan 16, 2025

The issue being ran into is from fmt from the kompute backend, that part will likely get skipped in a ROCm build (since ROCm is an alternative to kompute)

@maxamillion
Copy link
Collaborator Author

Thank you for the detailed response, I'll get that fixed up and test it. :)

@maxamillion
Copy link
Collaborator Author

that fixed it! PR here #596 ... thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants