Add support for --override-platform flag #2175
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Rittner <[email protected]>
mtrmac
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Thanks!
My immediate reaction is that I don’t know how I feel about the way platforms.Parse defaults values; compare #1987 (comment) . The trade-off is consistency with containerd, which is certainly somewhat valuable.
Either way, this and #1987 should probably end up with a consistent answer to this trade-off.
|
@nalind thoughts? |
|
This doesn't break anything, and it gets us closer to not being in the business of figuring out for ourselves which "variant" value to use on ARM boxes, so I'm fine with it. If that means reworking #1987, or scrapping it entirely, I'm not going to be particularly upset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2118.