From 35dfe374451b581373d4502319ab8bdc3bcc0631 Mon Sep 17 00:00:00 2001 From: Nate Date: Fri, 31 Jan 2025 23:19:02 -0800 Subject: [PATCH] update ci --- .github/workflows/pr_checks.yaml | 58 +------------------------------- 1 file changed, 1 insertion(+), 57 deletions(-) diff --git a/.github/workflows/pr_checks.yaml b/.github/workflows/pr_checks.yaml index ccc9e8a448..6cf26a4f10 100644 --- a/.github/workflows/pr_checks.yaml +++ b/.github/workflows/pr_checks.yaml @@ -1,7 +1,7 @@ name: PR checks on: - pull_request_target: + pull_request: branches: - main paths: @@ -22,21 +22,10 @@ on: - ".github/workflows/**" jobs: - validate-pr: - runs-on: ubuntu-latest - environment: tests-requiring-secrets - steps: - - uses: actions/checkout@v4 - install-root: - needs: validate-pr runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - # This is important - it switches from the base repo to the fork - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -57,9 +46,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -86,12 +72,8 @@ jobs: core-checks: needs: install-core runs-on: ubuntu-latest - environment: tests-requiring-secrets steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -122,9 +104,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -157,9 +136,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -191,9 +167,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -231,9 +204,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -268,9 +238,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -303,9 +270,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -333,9 +297,6 @@ jobs: test_file_matrix: ${{ steps.vscode-get-test-file-matrix.outputs.test_file_matrix }} steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - name: Cache node modules uses: actions/cache@v3 @@ -363,9 +324,6 @@ jobs: needs: [install-vscode, install-core] steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -399,9 +357,6 @@ jobs: needs: [install-vscode, install-core] steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -443,7 +398,6 @@ jobs: ] runs-on: ubuntu-latest # Tests requiring secrets need approval from maintainers - environment: tests-requiring-secrets strategy: fail-fast: false matrix: @@ -451,9 +405,6 @@ jobs: command: ["e2e:ci:run", "e2e:ci:run-yaml"] steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -517,9 +468,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - uses: actions/setup-node@v4 with: @@ -552,10 +500,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - - uses: actions/cache@v4 with: path: core/node_modules