Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for ollama onboarding #3059

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

RomneyDa
Copy link
Collaborator

Description

Handle llm/listInfo returning empty object

Doesn't fix underlying issue of message type not being recognized

per @Patrick-Erichsen will probably be solved by strict null checks

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 3060600
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67440d3136c346000836730b

@sestinj sestinj merged commit 988d0b1 into main Nov 25, 2024
5 of 6 checks passed
@sestinj sestinj deleted the dallin/llm-list-models-bug branch November 25, 2024 15:45
@RomneyDa
Copy link
Collaborator Author

noting for future reference that underlying bug is that ideMessenger is returning an empty object when based on types that shouldn't be possible. So removing type casting and upcoming strict null checks should help long term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants