Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an official "setup-convco" GitHub workflow #243

Open
whichwit opened this issue Aug 9, 2024 · 7 comments
Open

Create an official "setup-convco" GitHub workflow #243

whichwit opened this issue Aug 9, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@whichwit
Copy link

whichwit commented Aug 9, 2024

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
Something akin to GitHub's actions/setup-dotnet. While it is not hard to incorporate the necessary steps separately, an official action will be a welcomed.

Describe alternatives you've considered
Incorporating the necessary steps to install convco during a workflow run.

@whichwit whichwit added the enhancement New feature or request label Aug 9, 2024
@hdevalke
Copy link
Collaborator

hdevalke commented Aug 9, 2024

I have no experience in writing a github action and how to make it compatible with different OSes and architectures.
Can you also describe how you would like to use the action? For which subcommand of convco: version/check/changelog?

I created a new repo convco-action where this can be developed: https://github.com/convco/convco-action

@whichwit
Copy link
Author

I have no experience with setting up GitHub actions either, although there should be plenty of examples to reference. I don't mind to give it a shot if I have additional capacity.

I like the simplicity of the tool so hoping it will gain popularity.

@hdevalke
Copy link
Collaborator

No problem I will try to make something when I find time. Thank you for liking convco.

@hdevalke
Copy link
Collaborator

I tried to create an action.

https://github.com/marketplace/actions/convco

Would you be able to try it out and give feedback?

@whichwit
Copy link
Author

Run convco/[email protected]
  with:
    command: check
    convco_version: latest
Error: Unable to locate executable file: /home/runner/work/vital-records-java/vital-records-java/entrypoint.sh. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

This is the error I got when trying to incorporate the action.

@whichwit
Copy link
Author

I should also clarify that I had hoped to only setup convco with the action request i.e. install via .deb (or something similar), so that convco can be called directly within the command line. Using an action step with associated command can be useful too, but would be harder to incorporate stdin/stdout from other steps.

@hdevalke
Copy link
Collaborator

I updated the action so it only installs convco.
You should be able to use this:

              - name: Convco install
                uses: convco/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants