Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard-version ignores errors within custom updater scripts #917

Open
jeloagnasin opened this issue Jul 13, 2022 · 1 comment
Open

standard-version ignores errors within custom updater scripts #917

jeloagnasin opened this issue Jul 13, 2022 · 1 comment
Labels

Comments

@jeloagnasin
Copy link

jeloagnasin commented Jul 13, 2022

Describe the bug
standard-version ignores errors within custom updater scripts.

Current behavior
If an error occurs in the custom updater, standard-version will ignore it. Then, it will continue bumping other files.

Expected behavior
If an error occurs in the custom updater, standard-version should stop and throw the error properly in the console. Or at the very least, standard-version should show properly formatted error logs so that it would catch the attention of the developer.

Environment

  • standard-version version(s): 9.5.0
  • Node/npm version: Node 16.15.1/npm 8.11.0
  • OS: OSX 12.4

Possible Solution
In https://github.com/conventional-changelog/standard-version/blob/master/lib/lifecycles/bump.js#L144, there should be at least an error log to catch the attention of the developer.

Additional context
Here is a sample repo to replicate the issue: https://github.com/jeloagnasin/standard-version-issue

@jeloagnasin
Copy link
Author

Create a PR to improve console logs: #918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant