Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signin with email and password #174

Open
rodgomesc opened this issue Aug 18, 2020 · 6 comments
Open

signin with email and password #174

rodgomesc opened this issue Aug 18, 2020 · 6 comments
Assignees
Labels
breaking The resolution creates a breaking API change client Issues related to the client enhancement New feature or request server Issues related to the server
Milestone

Comments

@rodgomesc
Copy link

rodgomesc commented Aug 18, 2020

Versions
Please fill in all that apply:

  • Convergence Version: 1.0.0-rc.7
  • OS: Linux
  • Browser: all
  • Java Version: openjdk 11

Description

hello, guys, I didn't see anything in the documentation related to login with email and password, only with username, jwt, or anonymously, would it be possible to do this implementation? or if you can show me some methods responsible for the login, and their flows, I could try to implement, thanks

@rodgomesc rodgomesc added the enhancement New feature or request label Aug 18, 2020
@mmacfadden mmacfadden self-assigned this Aug 18, 2020
@mmacfadden mmacfadden added this to the 1.0.0-rc.8 milestone Aug 18, 2020
@mmacfadden
Copy link
Contributor

You are correct, this feature does not exist. I think this would be pretty easy to add. We will add this shortly.

@rodgomesc
Copy link
Author

thank you, i will implement this project in a service that i am developing, so i must be more familiar with the convergence code sun, and i will be able to contribute, as soon as i can contribute i will start implementing a client in python and ruby, from what i have seen so far it didn't seem so complicated

@mmacfadden
Copy link
Contributor

The client side is not too complicated. We would love to collaborate with you.

@mmacfadden mmacfadden added breaking The resolution creates a breaking API change client Issues related to the client server Issues related to the server labels Aug 23, 2020
@mmacfadden
Copy link
Contributor

mmacfadden commented Aug 23, 2020

We are working on this now. This will likely involve a small breaking API change. RIght now we have the following method:

public connectWithPassword(credentials: IUsernameAndPassword | (() => Promise<IUsernameAndPassword>)): Promise<void> 

And IUsernameAndPassword looks like:

export interface IUsernameAndPassword {
  username: string;
  password: string;
}

We will update this to be:

export interface IPasswordCredential {
  username?: string;
  email?: string;
  password: string;
}

This will allow the caller to provide an email or username. The Interface name will change though, to correctly name the interface. Not a big change, but it will be breaking.

@rodgomesc
Copy link
Author

rodgomesc commented Aug 23, 2020

sounds good,

when ready i will test it, thanks

@mmacfadden
Copy link
Contributor

One thing I did find, looking at the domain schema it appears that email is not a unique constraint for domain users. I would think we would need to make domain user emails unique if this were going to work.

@mmacfadden mmacfadden modified the milestones: 1.0.0-rc.8, 1.0.0-rc.9 Oct 24, 2020
@mmacfadden mmacfadden modified the milestones: 1.0.0-rc.9, Backlog May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking The resolution creates a breaking API change client Issues related to the client enhancement New feature or request server Issues related to the server
Projects
None yet
Development

No branches or pull requests

2 participants