Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cxl-tabs-slider): hide scrollbars #146

Open
lkraav opened this issue May 19, 2021 · 4 comments
Open

refactor(cxl-tabs-slider): hide scrollbars #146

lkraav opened this issue May 19, 2021 · 4 comments
Assignees

Comments

@lkraav
Copy link

lkraav commented May 19, 2021

Feels like horizontal scrollbar doesn't make sense here: add visual noise, and arrows already indicate content overflow

image

Can we patch out scrollbar display?

@anoblet
Copy link
Collaborator

anoblet commented May 20, 2021

anoblet#14

@lkraav
Copy link
Author

lkraav commented Feb 21, 2023

On further consideration, scrollbars should be displayed in case of horizontal overflow.

Next step: verify what the exact state of the current component UX is.

@anoblet
Copy link
Collaborator

anoblet commented Feb 21, 2023

Currently scrollbars are displayed on all instances of cxl-tab-slider where there are enough items to overflow.

There is a PR open to make this conditional on a [show-scrollbar] property (anoblet#14).

@lkraav
Copy link
Author

lkraav commented Feb 21, 2023

Currently scrollbars are displayed on all instances of cxl-tab-slider where there are enough items to overflow.

Sounds great, probably nothing else needed.

Only thing I've noticed is that horizontal scroll could work with swipes / mouse drags. Not sure what needs to happen to get that behavior. Is it maybe built-in with Tabs and we've disabled it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants