Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxl jwplayer upgrades & tweaks #239

Closed
wants to merge 37 commits into from
Closed

cxl jwplayer upgrades & tweaks #239

wants to merge 37 commits into from

Conversation

saas786
Copy link

@saas786 saas786 commented Nov 15, 2022

No description provided.

@saas786 saas786 mentioned this pull request Nov 15, 2022
Closed
@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 44.75 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 14.53 KB (+22.21% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 29.23 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 157.96 KB (+14.28% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 305.03 KB (+9.9% 🔺)

@saas786 saas786 mentioned this pull request Nov 15, 2022
Closed
@saas786 saas786 force-pushed the syed/feat/cxl-jw-player branch 3 times, most recently from 0f9111c to 08b3cf5 Compare November 30, 2022 11:40
@saas786 saas786 marked this pull request as ready for review November 30, 2022 11:52
@saas786 saas786 self-assigned this Nov 30, 2022
@saas786 saas786 added the enhancement New feature or request label Nov 30, 2022
@saas786 saas786 force-pushed the syed/feat/cxl-jw-player branch 6 times, most recently from 9febe93 to 22fa914 Compare December 1, 2022 15:00
@lkraav
Copy link

lkraav commented Dec 14, 2022

Is there a Before / After screencast you could record for this? Or side-by-side even.

@anoblet
Copy link
Collaborator

anoblet commented Feb 20, 2023

/rebase

saas786 and others added 8 commits February 20, 2023 15:40
@saas786 @anoblet
feat(cxl-ui): rename jw player component
5121b7c 
Co-authored-by: Andrew Noblet <[email protected]>
@saas786 @anoblet
feat(cxl-ui): tweak jw player component
6bd1eb3 
Co-authored-by: Andrew Noblet <[email protected]>
@saas786 @anoblet
feat(cxl-ui): rename caption mixin to transcript mixin
4ff8d22 
Co-authored-by: Andrew Noblet <[email protected]>
@saas786 @anoblet
feat(cxl-ui): tweak transcript mixin
6b74e43 
Co-authored-by: Andrew Noblet <[email protected]>
@saas786 @anoblet
feat(cxl-ui): rename chapter mixin to chapter navigation mixin
7391356 
Co-authored-by: Andrew Noblet <[email protected]>
@saas786 @anoblet
feat(cxl-ui): tweak chapter navigation mixin
67aba0d 
Co-authored-by: Andrew Noblet <[email protected]>
@saas786 @anoblet
feat(cxl-ui): add cxl-jw-player-transcript element
d6433d6 
Co-authored-by: Andrew Noblet <[email protected]>
@saas786 @anoblet
feat: cleanup, refactor & improve the code for PHP cxl/jw-player
5698fd1 
* jw-player height tweaks
* [jw-player] add support for sources
	cherry-pick: #236
* [cxl-jw-player] set up api endpoint
	cherry-pick: #234
@anoblet anoblet force-pushed the syed/feat/cxl-jw-player branch 2 times, most recently from 865b87c to b1ce82a Compare March 3, 2023 15:51
@anoblet anoblet force-pushed the syed/feat/cxl-jw-player branch 2 times, most recently from 28776ad to d84367b Compare March 7, 2023 14:44
@anoblet anoblet force-pushed the syed/feat/cxl-jw-player branch 4 times, most recently from 6ebe588 to 59fa864 Compare March 8, 2023 19:08
@anoblet anoblet requested a review from pawelkmpt April 14, 2023 16:28
@anoblet
Copy link
Collaborator

anoblet commented Apr 14, 2023

Would someone be able to take a look at this next week? It would be nice to use cxl-jw-player instead of Vimeo in the cxl-app-layout-2c-r story. This would help when tackling this issue: https://app.clickup.com/t/861mb94pw

@pawelkmpt
Copy link

@lkraav

@anoblet
Copy link
Collaborator

anoblet commented Sep 11, 2024

Closed in favor of: #433

@anoblet anoblet closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoblet anoblet anoblet left review comments

@lkraav lkraav Awaiting requested review from lkraav

@pawelkmpt pawelkmpt Awaiting requested review from pawelkmpt

Assignees

@anoblet anoblet

Labels
enhancement New feature or request jw-player
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saas786 @lkraav @anoblet @pawelkmpt