Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cxl-ui): fix poor visibility of main category tag in cards #351

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(cxl-ui): fix poor visibility of main category tag in cards #351

merged 1 commit into from
Oct 26, 2023

Conversation

freudFlintstone
Copy link

@github-actions
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 63.65 KB (+0.01% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.66 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 239.91 KB (+0.01% 🔺)

@lkraav
Copy link

lkraav commented Oct 25, 2023

Before / After screenshots directly in PR would help review things faster, on the go on mobile, etc.

@freudFlintstone
Copy link
Author

@lkraav
Before:
Screenshot from 2023-10-25 18-39-01
After:
Screenshot from 2023-10-25 18-39-15

pawelkmpt
pawelkmpt approved these changes Oct 26, 2023
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for @heshfekry reply before merging

@pawelkmpt pawelkmpt merged commit 8ce32ba into master Oct 26, 2023
5 checks passed
@pawelkmpt
Copy link

Task linked: CU-86ayjuqbj Quick fix Post type style on full cards

@pawelkmpt pawelkmpt deleted the raphael/fix/course-cards/font-styles branch October 31, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelkmpt pawelkmpt pawelkmpt approved these changes

@lkraav lkraav Awaiting requested review from lkraav

@anoblet anoblet Awaiting requested review from anoblet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freudFlintstone @lkraav @pawelkmpt