refactor(cxl-ui): cxl-star-rating remove _updateReadonlyAndValue #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyAndValue This is necessary to prevent the component from saving default value on each usage case. We prefer it being zero at all times. https://app.clickup.com/t/86azy6kx9?comment=90140034479841&threadedComment=90140035014093
size-limit report 📦
|
What did we save the value for - so user would know they've already rated something? |
pawelkmpt
reviewed
May 7, 2024
paulkirspuu
force-pushed
the
paul/refactor/star-rating-remove-readonly
branch
from
1b66e85
to
0627569
Compare
Component was developed for playbooks and I don't remember if ever used. There was an alternative thumbs up/down component too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to prevent the component from saving default value on each usage case.
We prefer it being zero at all times.
https://app.clickup.com/t/86azy6kx9?comment=90140034479841&threadedComment=90140035014093