-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cxl-ui): re-implement navigation bar #341
Conversation
size-limit report 📦
|
f621126
to
b35e2de
Compare
b35e2de
to
2f640f8
Compare
packages/cxl-lumo-styles/scss/themes/vaadin-context-menu-item.scss
Outdated
Show resolved
Hide resolved
packages/cxl-lumo-styles/scss/themes/vaadin-context-menu-list-box.scss
Outdated
Show resolved
Hide resolved
I'll update my branch to get rid of the old component and avoid WPS changes. I have 110 places to check in aybolit, so it will take me a little while. |
"After categories" came from other menu tree. |
cfb17a9
to
7e8735d
Compare
9c220ca
to
debe3d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pawelkmpt The old component is now completely gone, including any styles in cxl-ui and cxl-lumo-styles that were realted to it. The odd menu items, however, need more investigating, and possibily some database cleanup. It's also likely there are WPS styles overriding the color of the text on the global bar.
debe3d7
to
0a341ca
Compare
0f6cce9
to
5cbe29e
Compare
5737311
to
711d7db
Compare
2e33907
to
b2415bb
Compare
Task linked: CU-86ayraehj Front-end bit of nav bar facelift |
b2415bb
to
0d8b3f8
Compare
36b2f3d
to
d30a334
Compare
It was still a mess. I cleaned, rebased and force pushed @freudFlintstone |
d30a334
to
c1784bb
Compare
https://app.clickup.com/t/86ayah2zr
POC for navigation component using
vaadin-menu-bar
instead ofvaadin-tabs
, aiming to have a standard context menu UI.Because the menu-bar component also uses
vaadin-context-menu
under the hood, it looks and behaves largely the same as the current custom implementation, even with little CSS work.Initial implementation brings the navigation component down from nearly 700 lines of code to about 80. If this is used in place of the current component, a lot of CSS can also be cleaned up.