From c71a6161af061d85738ac1e5a4853a36183abd89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Kopoci=C5=84ski?= Date: Thu, 13 Jun 2024 12:18:04 +0200 Subject: [PATCH 1/2] refactor(cxl-ui): use index-institute for learning components Create new dist JS file including components for institute part of CXL. Avoid loading all possible components on the blog site as it doesn't user them. --- packages/cxl-ui/src/index-core.js | 12 ------------ packages/cxl-ui/src/index-institute.js | 12 ++++++++++++ packages/cxl-ui/webpack.mix.js | 2 ++ 3 files changed, 14 insertions(+), 12 deletions(-) create mode 100644 packages/cxl-ui/src/index-institute.js diff --git a/packages/cxl-ui/src/index-core.js b/packages/cxl-ui/src/index-core.js index 3763ab40b..cab67c1b1 100644 --- a/packages/cxl-ui/src/index-core.js +++ b/packages/cxl-ui/src/index-core.js @@ -17,23 +17,11 @@ import * as Headroom from 'headroom.js'; export { CXLAppLayoutElement } from './components/cxl-app-layout.js'; export { CXLBaseCardElement } from './components/cxl-base-card.js'; export { CXLCardElement } from './components/cxl-card.js'; -export { CXLCredentialElement } from './components/cxl-credential.js'; export { CXLCourseCardElement } from './components/cxl-course-card.js'; -export { CXLCourseDialogElement } from './components/cxl-course-dialog.js'; -export { CXLCheckoutDetailsElement } from './components/cxl-checkout-details.js'; -export { CXLDashboardHeaderElement } from './components/cxl-dashboard-header.js'; -export { CXLCertificateHeaderElement } from './components/cxl-certificate-header.js'; -export { CxlDashboardSectionElement } from './components/cxl-dashboard-section.js'; -export { CXLDashboardNotificationElement } from './components/cxl-dashboard-notification.js'; -export { CxlDashboardTeamHeaderElement } from './components/cxl-dashboard-team-header.js'; -export { CxlDashboardTeamStatsElement } from './components/cxl-dashboard-team-stats.js'; -export { CXLFeaturedCourseCardElement } from './components/cxl-featured-course-card.js'; export { CXLLightCardElement } from './components/cxl-light-card.js'; export { CXLNotification } from './components/cxl-notification.js'; -export { CXLNotificationCardElement } from './components/cxl-notification-card.js'; export { CXLSectionElement } from './components/cxl-section.js'; export { CXLStarRatingElement } from './components/cxl-star-rating.js'; -export { CXLStatsElement } from './components/cxl-stats.js'; export { CXLTabsSliderElement } from './components/cxl-tabs-slider.js'; export { CXLMarketingNavElement } from './components/cxl-marketing-nav.js'; diff --git a/packages/cxl-ui/src/index-institute.js b/packages/cxl-ui/src/index-institute.js new file mode 100644 index 000000000..3c90ed662 --- /dev/null +++ b/packages/cxl-ui/src/index-institute.js @@ -0,0 +1,12 @@ +export { CXLCredentialElement } from './components/cxl-credential.js'; +export { CXLCourseDialogElement } from './components/cxl-course-dialog.js'; +export { CXLCheckoutDetailsElement } from './components/cxl-checkout-details.js'; +export { CXLDashboardHeaderElement } from './components/cxl-dashboard-header.js'; +export { CXLCertificateHeaderElement } from './components/cxl-certificate-header.js'; +export { CxlDashboardSectionElement } from './components/cxl-dashboard-section.js'; +export { CXLDashboardNotificationElement } from './components/cxl-dashboard-notification.js'; +export { CxlDashboardTeamHeaderElement } from './components/cxl-dashboard-team-header.js'; +export { CxlDashboardTeamStatsElement } from './components/cxl-dashboard-team-stats.js'; +export { CXLFeaturedCourseCardElement } from './components/cxl-featured-course-card.js'; +export { CXLNotificationCardElement } from './components/cxl-notification-card.js'; +export { CXLStatsElement } from './components/cxl-stats.js'; diff --git a/packages/cxl-ui/webpack.mix.js b/packages/cxl-ui/webpack.mix.js index 9c351898c..22c4bcf19 100644 --- a/packages/cxl-ui/webpack.mix.js +++ b/packages/cxl-ui/webpack.mix.js @@ -11,6 +11,7 @@ */ // Import required packages. +// eslint-disable-next-line import/no-extraneous-dependencies const mix = require('laravel-mix'); /* @@ -81,6 +82,7 @@ mix.version(); mix .js(`${devPath}/index-core.js`, `${distPath}/cxl-ui.js`) + .js(`${devPath}/index-institute.js`, `${distPath}/cxl-ui-institute.js`) .js(`${devPath}/index-playbooks.js`, `${distPath}/cxl-ui-playbooks.js`) .js(`${devPath}/index-jwplayer.js`, `${distPath}/cxl-ui-jwplayer.js`); From 1347b54be9ea83bafe6592b94590ebab844e27dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Kopoci=C5=84ski?= Date: Thu, 13 Jun 2024 13:48:04 +0200 Subject: [PATCH 2/2] refactor(cxl-ui): index-core remove compiling cxl-playbook-* components --- packages/cxl-ui/src/index-core.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/cxl-ui/src/index-core.js b/packages/cxl-ui/src/index-core.js index cab67c1b1..95b6d5c23 100644 --- a/packages/cxl-ui/src/index-core.js +++ b/packages/cxl-ui/src/index-core.js @@ -25,16 +25,8 @@ export { CXLStarRatingElement } from './components/cxl-star-rating.js'; export { CXLTabsSliderElement } from './components/cxl-tabs-slider.js'; export { CXLMarketingNavElement } from './components/cxl-marketing-nav.js'; -/** - * Order matters. - * - * Note: - * `CXLPlaybookProgressBarElement` belong's to `index-playbooks`, - * but it doesn't work there, so placed instead, because these elements are related and order matters too. - */ +// Order matters. export { CXLVaadinAccordionElement } from './components/cxl-vaadin-accordion.js'; -export { CXLPlaybookProgressBarElement } from './components/cxl-playbook-progress-bar.js'; -export { CXLPlaybookAccordionElement } from './components/cxl-playbook-accordion.js'; export { CXLAccordionCardElement } from './components/cxl-accordion-card.js'; // @todo maybe https://github.com/tc39/proposal-export-default-from