Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ServiceResultException serializable #241

Closed
wants to merge 1 commit into from
Closed

make ServiceResultException serializable #241

wants to merge 1 commit into from

Conversation

trivalik
Copy link
Contributor

fixes #235

@trivalik
Copy link
Contributor Author

Is there any reason why this is not done yet?

@awcullen
Copy link
Contributor

I don't believe SerializableAttribute is recommended any more for current dotnet.

@awcullen awcullen closed this May 31, 2023
@trivalik
Copy link
Contributor Author

trivalik commented May 31, 2023 •
edited
Loading

I guess you mean deprecation of binaryformatter: https://learn.microsoft.com/en-us/dotnet/core/compatibility/serialization/5.0/binaryformatter-serialization-obsolete

I don't think it is the case for xml serialization.

Other project do allow serialization as well like rabbitmq/rabbitmq-dotnet-client#684

@trivalik trivalik deleted the serializableException branch April 8, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception objects should be serializable
2 participants
@trivalik @awcullen