Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom serialization/deserialization code broken #4

Open
abyrd opened this issue Apr 19, 2015 · 1 comment
Open

Custom serialization/deserialization code broken #4

abyrd opened this issue Apr 19, 2015 · 1 comment

Comments

@abyrd
Copy link
Member

abyrd commented Apr 19, 2015

MapDB has two levels of cache. The serialized data is cached in the sense that the OS will cache memory-mapped file pages. The deserialized objects are cached in an instance cache.

Osm-lib was only working for fetching data because the instance cache was set to a really huge size, and all the objects were remaining in instance cache.

In fact, the deserialization code fails with an exception. I discovered this by calling MapDB's cacheDisable() and/or setting the instance cache size much smaller. Therefore we aren't actually sure that a round trip through MapDB preserves the OSM data.

We need a test that does thorough comparisons using cacheDisable() to make sure deserialization works right!

@abyrd
Copy link
Member Author

abyrd commented Jun 22, 2015

This should be fixed now, but we should still have tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant