Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor SkJson 4.1.0 #110

Open
cooffeeRequired opened this issue Nov 18, 2024 · 1 comment · Fixed by #114 · May be fixed by #109
Open

Refractor SkJson 4.1.0 #110

cooffeeRequired opened this issue Nov 18, 2024 · 1 comment · Fixed by #114 · May be fixed by #109
Assignees

Comments

@cooffeeRequired
Copy link
Owner

No description provided.

@cooffeeRequired cooffeeRequired self-assigned this Nov 18, 2024
@cooffeeRequired cooffeeRequired linked a pull request Nov 18, 2024 that will close this issue
@cooffeeRequired
Copy link
Owner Author

Pull Request: Enhanced Logging and Metrics Initialization

Author: @localChanges
Date: 2023-10-05

Summary

This pull request includes improvements to the SkJson plugin, focusing on logging enhancements and initializing metrics collection using bStats.

Changes

  1. Enhanced Logging:

    • Added robust logging during plugin load and enable phases.
    • Improved error handling and logging for JsonFileWatcher.
  2. Metrics Initialization:

    • Implemented bStats metrics initialization in the setupMetrics method.
    • Added custom charts for skript_version and skjson_version.

Detailed Description

Enhanced Logging

Note

Logging now includes more contextual information and error handling.

  • Initialization Phase (onLoad):

    • The logger is initialized with the plugin's name.
    • A check and log output for the presence of JsonFileWatcher.
  • Enable Phase (onEnable):

    • Added detailed startup logging.
    • Included permission checks and feedback through the about command.

Metrics Initialization

Important

Integrates bStats for usage tracking and analytics.

  • Metrics Setup:
    • Utilizes bStats to track the plugin version and Skript version in use.
    • This is initialized in the setupMetrics method, with specific custom charts added for plugin versioning.

Testing

  1. Setup Environment:
    • Ensure bStats is included in the build.
    • Verify the SkJson plugin initializes without errors.
  2. Validation:
    • Check logs for proper initialization messages.
    • Verify metrics appear correctly on the bStats dashboard.

Additional Notes

  • Make sure to review the logger format and confirm the bStats functionality after merging.
  • Pay attention to any potential ClassNotFoundException if dependencies change.

Screenshots

No visual changes included.

Please Review:

  • Code accuracy and completeness.
  • Integration with bStats.
  • Logging output for readability and completeness.

Thank you!

/cc @teamReviewers

@cooffeeRequired cooffeeRequired linked a pull request Dec 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant