-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SerialPort 9x -> 10.x problem #19
Comments
See coolchip/node-comfoair#19 for explanation
Hello @VincentSC , do you know, what to change here: https://github.com/coolchip/node-red-contrib-comfoair/blob/master/comfoair-connection.js |
A month ago I moved to MacOS and I had no dev-env there yet. I think I can make a PR this week, as it's now set up. @coolchip Got time later this week to review that PR? |
Hi Sebastian,
Long time not "spoken"! :)
I got a problem since some time, and I did not realize till today it was in this package caused by 3460ba4
node-red-contrib-comfoair
gives these errors:Eventually I got here: https://serialport.io/docs/guide-upgrade#upgrading-from-9x-to-10x
Everywhere this needs to change:
const SerialPort = require('serialport');
->const { SerialPort } = require('serialport');
.has to change to
I tested successfully with both downgrading back to serialport 9.2.8 and the above fixes with 10.5.0.
The text was updated successfully, but these errors were encountered: