Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poncho: Simplify import failure #3893

Closed
dthain opened this issue Jul 31, 2024 · 2 comments
Closed

Poncho: Simplify import failure #3893

dthain opened this issue Jul 31, 2024 · 2 comments
Assignees

Comments

@dthain
Copy link
Member

dthain commented Jul 31, 2024

BenC pointed this out in a Parsl issue:
Parsl/parsl#3552

Basically, we are trying too hard to capture an import error and replace it with something more explanatory. (There may have been a reason for this in the past.). Now that we rely on Conda to get proper python environments everywhere, we should just import normally and (if that fails) let it fail with the normal exception.

@dthain
Copy link
Member Author

dthain commented Aug 7, 2024

Barry, can you do this one up quickly? I think it's a small change and then we can close it out...

@BarrySlyDelgado
Copy link
Contributor

We now let the import errors happen by forgoing catching the exception via #3907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants