vine: inconsistent usage of BYTES_TO_MEGABYTES

[JinZhou5042]

There are some places where BYTES_TO_MEGABYTES is used directly, while others apply ceil().

I’m wondering if these different usages could lead to inconsistencies in calculations, potentially accumulating errors over several hours as the system processes millions of replicas.

Code using ceil(BYTES_TO_MEGABYTES)

// 1. vine_file_replica_table_insert()
double prev_available = w->resources->disk.total - ceil(BYTES_TO_MEGABYTES(w->inuse_cache + replica->size));
// 2. vine_file_replica_table_insert()
m->current_max_worker->disk = w->resources->disk.total - ceil(BYTES_TO_MEGABYTES(w->inuse_cache));
// 3. count_worker_resources()
w->resources->disk.inuse += ceil(BYTES_TO_MEGABYTES(w->inuse_cache));
// 4. aggregate_workers_resources()
*inuse_cache = (int64_t)ceil(BYTES_TO_MEGABYTES(*inuse_cache));

Code using BYTES_TO_MEGABYTES

// 1. vine_file_replica_table_remove()
double available = w->resources->disk.total - BYTES_TO_MEGABYTES(w->inuse_cache);
// 2. handle_cache_update()
w->resources->disk.inuse += BYTES_TO_MEGABYTES(size);
// 3. vine_manager_choose_resources_for_task()
int64_t available_disk = w->resources->disk.total - BYTES_TO_MEGABYTES(w->inuse_cache);
// 4. update_max_worker()
if (q->current_max_worker->disk < (w->resources->disk.total - BYTES_TO_MEGABYTES(w->inuse_cache))) {
    q->current_max_worker->disk = w->resources->disk.total - BYTES_TO_MEGABYTES(w->inuse_cache);
}

[btovar]

Good catch! Yes, we should we doing the same everywhere. I'd suggest modifying the macro itself to ensure the same use in each case.

[JinZhou5042]

fixed in #4088