Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should gickup error on unknown keywords, invalid/malformed configs #249

Open
vic1707 opened this issue Jul 28, 2024 · 0 comments
Open

should gickup error on unknown keywords, invalid/malformed configs #249

vic1707 opened this issue Jul 28, 2024 · 0 comments

Comments

@vic1707
Copy link

vic1707 commented Jul 28, 2024

When testing configs for the purpose explained in #248 I went and tried

# ...
source:
    github:
        # ....
        - organization: Zelda-Reverse-Engineering-Team
          token_file: /config/token # fine grained token for vic1707

And realized that everything my token had access to was getting downloaded. Shouldn't gickup have some kind of config checks and error on invalid/malformed config ?

First I went crazy speculating some cache was messing with me when it was simply a missconfig and gickup was ignoring organization: Zelda-Reverse-Engineering-Team (tried user before but didn't do the trick)

@vic1707 vic1707 changed the title should gickup error on unknown keywords should gickup error on unknown keywords, invalid/malformed configs Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant