Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion between stdlib and stdlib-flambda when it fails #335

Open
SkySkimmer opened this issue Feb 9, 2025 · 3 comments
Open

Confusion between stdlib and stdlib-flambda when it fails #335

SkySkimmer opened this issue Feb 9, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@SkySkimmer
Copy link
Contributor

coq/coq#20215 (comment)

🏃 @coqbot ci minimize will minimize the following targets: ci-stdlib, ci-stdlib

@ticket-tagger ticket-tagger bot added the bug Something isn't working label Feb 9, 2025
@JasonGross
Copy link
Member

As far as I can tell

bot/src/actions.ml

Lines 1007 to 1012 in e838d62

let shorten_ci_check_name target =
target
|> Str.global_replace (Str.regexp "GitLab CI job") ""
|> Str.global_replace (Str.regexp "(pull request)") ""
|> Str.global_replace (Str.regexp "(branch)") ""
|> Stdlib.String.trim
seems fine ... I'm trying to find/recall where the library: / plugin: bits get chopped off

@JasonGross
Copy link
Member

JasonGross commented Feb 9, 2025

The solution should be to just include + in

if string_match ~regexp:"\\([^: ]*\\):\\(ci-[A-Za-z0-9_-]*\\)" full_name

I don't have time to take care of & test this right now, unfortunately

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 10, 2025

I don't think fixing this is as trivial as adding + to this regexp, because while the CI job is called ci-stdlib+flambda, the Makefile.ci target is ci-stdlib. So, we would need specific support for +flambda jobs (or +whatever jobs) for which we would be able to store a separate GitLab job name and Makefile.ci target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants