Removed INSTALLATION_IN_PROGRESS const (was always true and used badly)

common/Config.php

@@ -70,9 +70,6 @@ public static function getSettingsFor($module_name) {
 	}
 
 	public static function loadTemporaryDBSettings($database_settings) {
-		if (!INSTALLATION_IN_PROGRESS)
-			throw new Exception("This method can only be used during installation.", self::ERR_NOT_INSTALLING);
-
 		if (!isset(self::$module_settings["database"]))
 			self::$module_settings["database"] = [];
 		self::$module_settings["database"] = array_merge(self::$module_settings["database"], $database_settings);

common/DBService.php

@@ -26,7 +26,7 @@ class DBService extends Object {
 	protected static $db = null;
 	protected $error;
 
-	public function __construct($dbname = null)
+	public function __construct($databaseName = null)
 	{
 		if (!self::$db)
 		{
@@ -62,9 +62,8 @@ public function __construct($dbname = null)
 			}
 		}
 
-		// Allow db not to be selected if installation in progress
-		if ($dbname !== false && INSTALLATION_IN_PROGRESS)
-			self::selectDB($dbname ? $dbname : Config::dbInfo("name"));
+		if ($databaseName !== false)
+			self::selectDB($databaseName ? $databaseName : Config::dbInfo("name"));
 	}
 
 	public function getError()

install/index.php

@@ -68,10 +68,6 @@
 $INSTALLATION_VERSION = "2.0.0";
 $INSTALLATION_VERSIONS = ["1.9.0", "2.0.0"];
 
-// TODO: if /index.php is calling this all the time, these lines make no sense
-// 			(we shouldn't set these constants for every page).
-const INSTALLATION_IN_PROGRESS = true;
-
 
 function is_installed()
 {