Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image __toString not correctly implemented #65

Open
cjke opened this issue Mar 10, 2018 · 0 comments
Open

Image __toString not correctly implemented #65

cjke opened this issue Mar 10, 2018 · 0 comments

Comments

@cjke
Copy link
Contributor

cjke commented Mar 10, 2018

Image extends BasicField, and provides some abstract base methods - __toString causes an issue with Image in particular as it invokes ->get() as get() for Image returns an Image instance.

__toString must always return a string.

Happy to shoot through a PR. Simplest solution would probably just to overwrite the abstract method __toString in image with something like:

    /**
     * @return string
     */
    public function __toString()
    {
        return $this->url;
    }

This was covered in #60 but it was closed because it wasn't explained in detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant