-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nlog.Loki.dll is not copied to bin directory when used as a sub project #114
Comments
Hi, Would publishing the NuGet package explicitly targetting .NET Framework 4.8 solve the issue? We could try that out. Would you like to give it a try to see if it solves your issue? If so, I can update the build and publish scripts accordingly. |
This is only an idea of adding support for .NET Framework 4.8, following issue #114. This proof of concept is not ready to be merged. * The added dependencies must be conditioned to only .NET Framework 4.8. * The Json serliazing logic must be conditioned to .NET Framework 4.8 to avoid performance degradation for .NET 6+ users. * Documentation and build, test, publish pipelines must be updated accordingly
Thanks for the response, yes I believe publishing explicitly for .net 4.8 would fix the issue!
|
Hi, Thanks for creating this. We have created a shared logging library in .NET Framework 4.8 which references Nlog.Loki.dll 2.1.1
We have setup a parent solution and sub projects.
Solution
Everything works fine if we have a reference to Loki in Project B and the Nlog.Loki.dll is copied to the bin directory of project B.
If the Loki reference is removed from Project B, then the Nlog.Loki.dll is not copied to the bin directory. It is marked as CopyLocal in the ProjectA project. NLog 5 works as expected and is copied to Project B bin directory although there is not reference to it in Project B.
It appears to be something to do with the Loki dll being .netstandard 2.0, I've tried various stackoverflow suggestions like
https://stackoverflow.com/questions/70082582/net-standard-dependency-not-copied-to-output-directory
However the loki dll will not be copied unless it's added as a reference (Verbose build output) show's nothing helpful.
Anyone encountered this?
The text was updated successfully, but these errors were encountered: