Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop composefs setting #3732

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

Since ostreedev/ostree#3165 this can be configured in the ostree commit itself.

Since ostreedev/ostree#3165
this can be configured in the ostree commit itself.
@cgwalters
Copy link
Member Author

Comment on lines -338 to -345
# See https://github.com/coreos/coreos-assembler/pull/1379 - we want the local
# dev case to explicitly fetch updates when they want them, plus CI pipelines
# generally want to react to "changed or not" with a separate `fetch`.
# The fetched-stamp is new, in order to not break existing workdirs we assume
# a fetch was done if a successful build was done.
if [ ! -f "${workdir}"/builds/builds.json ] && [ ! -f "${fetch_stamp}" ] ; then
fatal "Must fetch before building"
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, removed by mistake?

@alexlarsson
Copy link

As I commented in ostreedev/ostree#3165, we still rely on the global setting to change the default of use_fsverity from NO to MAYBE. If this is dropped, then composefs with fs-verity will not work.

And really, this needs to be a global options, because objects are shared between images, so even if the image being pulled doesn't use composefs, another may reuse its objects and do use composefs.

@jlebon
Copy link
Member

jlebon commented May 9, 2024

Closing based on #3732 (comment).

@jlebon jlebon closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants