Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align codebase with openshift/cincinnati (prepare for folding back there) #3

Open
2 of 3 tasks
lucab opened this issue Nov 27, 2019 · 3 comments
Open
2 of 3 tasks

Comments

@lucab
Copy link
Contributor

lucab commented Nov 27, 2019

Once the development dust settles here, this project should be folded back into https://github.com/openshift/cincinnati.

A list of things that need to happen before being able to do that:

  • split into two binaries, fcos-graph-builder and fcos-policy-engine
  • decommission dumnati binary
  • rework graph-processing logic into plugins
@junjiequ

This comment has been minimized.

@lucab

This comment has been minimized.

@lucab
Copy link
Contributor Author

lucab commented Jun 29, 2020

Ratcheting changes here, I think a good first step would be introducing fcos-graph-builder binary first and capturing the shared logic in a commons library.
That can be deployed to fedora-infra in order to check that everything is fine, without impacting clients.

Once there, the next thing is landing fcos-policy-engine and routing request to it instead of dumnati. This is the most sensitive step as it impacts clients, so we should keep that in mind and make it easy to switch (perhaps running all the three components for some time and just switching the endpoint service in openshift).

After that, if all goes well, we can remove the dumnati crate.

zonggen pushed a commit to zonggen/fedora-coreos-cincinnati that referenced this issue Jul 8, 2020
This changes splits dumnati to two binaries and a library crate.
No content changes are added and only directory structure changes.

Related: coreos#3
Signed-off-by: Allen Bai <[email protected]>
zonggen pushed a commit to zonggen/fedora-coreos-cincinnati that referenced this issue Jul 9, 2020
This changes splits dumnati to two binaries and a library crate.
No content changes are added and only directory structure changes.

Makes fcos-policy-engine a dummy crate for now and adds additional
logic with follow-up PRs.

Related: coreos#3
Signed-off-by: Allen Bai <[email protected]>
zonggen pushed a commit to zonggen/fedora-coreos-cincinnati that referenced this issue Jul 9, 2020
This changes splits dumnati to two binaries and a library crate.
No content changes are added and only directory structure changes.

Makes fcos-policy-engine a dummy crate for now and adds additional
logic with follow-up PRs.

Related: coreos#3
Signed-off-by: Allen Bai <[email protected]>
zonggen pushed a commit to zonggen/fedora-coreos-cincinnati that referenced this issue Jul 14, 2020
This changes splits dumnati to two binaries and a library crate.
No content changes are added and only directory structure changes.

Makes fcos-policy-engine a dummy crate for now and adds additional
logic with follow-up PRs.

Related: coreos#3
Signed-off-by: Allen Bai <[email protected]>
zonggen pushed a commit to zonggen/fedora-coreos-cincinnati that referenced this issue Jul 14, 2020
This changes splits dumnati to two binaries and a library crate.
No content changes are added and only directory structure changes.

Makes fcos-policy-engine a dummy crate for now and adds additional
logic with follow-up PRs.

Related: coreos#3
Signed-off-by: Allen Bai <[email protected]>
@lucab lucab changed the title Fold back codebase into openshift/cincinnati Align codebase with openshift/cincinnati (prepare for folding back there) Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants