Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker: Rebase onto Fedora 40 #1674

Closed
50 of 52 tasks
jlebon opened this issue Feb 15, 2024 · 16 comments
Closed
50 of 52 tasks

tracker: Rebase onto Fedora 40 #1674

jlebon opened this issue Feb 15, 2024 · 16 comments
Labels

Comments

@jlebon
Copy link
Member

jlebon commented Feb 15, 2024

Rebase to a new version of Fedora (N=40)

At previous Fedora major release

Open tickets to track related work for this release

At Branching

Branching is when a new stream is "branched" off of rawhide. This eventually becomes the next major Fedora (N).

Release engineering changes

  • Verify that a few tags were created when branching occurred:

  • f${N+1}-coreos-signing-pending

  • f${N+1}-coreos-continuous

  • Add and tag a package (any package) which is in the stable repos into the continuous tag. This will create the initial yum repo that's used as input for building the COSA container.

  • koji add-pkg --owner ${FAS_USERNAME} f${N+1}-coreos-continuous $PKG

    • example: koji add-pkg --owner dustymabe f36-coreos-continuous fedora-release
    • This example uses the fedora-release RPM, but it could be any other.
  • koji tag-build f${N+1}-coreos-continuous $BUILD

    • example: koji tag-build f36-coreos-continuous fedora-release-36-0.16
  • Add the N+1 signing key short hash (usually found here) to the tag info for the coreos-pool tag. The following commands view the current settings and then update the list to the 32/33/34/35 keys. You'll most likely have to get someone from releng to run the second command (edit-tag).

    • koji taginfo coreos-pool
    • koji edit-tag coreos-pool -x tag2distrepo.keys="12c944d0 9570ff31 45719a39 9867c58f"

coreos-installer changes

  • Update coreos-installer to know about the signing key used for the future new major version of Fedora (N+1).
  • Drop the signing key for the obsolete stable release (N-2).

Update rawhide stream

Enable branched stream

  • Update manifest.yaml to list N as the releasever.
  • Update config.yaml to un-comment out the branched stream definition.

At Fedora (N) Beta

Update fedora-coreos-config next-devel

  • Bump releasever in manifest.yaml

  • Add the fedora-candidate-compose repo in manifest.yaml (example PR)

  • Update the repos in manifest.yaml if needed

  • Run cosa fetch --dry-run --update-lockfile

    • this updates the x86_64 lockfile - the others will get updated when bump-lockfile runs.
    • in the future we may support this in cosa fetch directly
  • PR the result

  • Re-enable next-devel if needed (docs)

  • Disable branched stream since it is no longer needed.

    • Update config.yaml to comment out the branched stream definition.

Ship rebased next

  • Ship next
  • Set a new update barrier for the final release of N-1 on next. In the barrier entry set a link to the docs. See discussion

Preparing for Fedora (N) GA

Do these steps as soon as we have a Go confirmation for GA, usually the Thursday of the week before GA.

Ship a final next release

If the packages in next-devel don't exactly match the last next release that was done, we need to do a release with the final GA content. This ensures that what we'll promote to testing has the exact content in GA (plus version fast-tracks). This usually happens on the Thursday of the announcement of Go.

  • Ensure final next release has GA content

Build rebased testing and final stable release on N-1

  • Build stable; promote it from the testing branch, which should still be on N-1. Don't release it yet (i.e. don't run the release job).
  • Build testing; promote it from the next branch instead of testing-devel. Don't release it yet (i.e. don't run the release job).

Update fedora-coreos-config testing-devel

  • Bump releasever in manifest.yaml
  • Update the repos in manifest.yaml if needed
  • Sync the lockfiles for all arches from next-devel
  • Bump the base Fedora version in ci/buildroot/Dockerfile
  • Change all the container references - grep -Pri 'registry.fedoraproject.org|quay.io/fedora/fedora:
  • PR the result

At Fedora (N) GA

Do these steps on GA day.

Release rebased testing and final stable release on N-1

  • Run the release job for the staged testing and stable builds and start rollout.
  • Set a new update barrier for the final release of N-1 on testing. In the barrier entry set a link to the docs. See discussion

Disable next-devel stream if not needed

We prefer to disable next-devel when there is no difference between testing-devel and next-devel. This allows us to prevent wasting a bunch of resources (bandwidth, storage, compute) for no reason. After the switch to N if next-devel and testing-devel are in lockstep, then disable next-devel.

  • Follow the instructions here to disable next-devel

Switch upstream packages to shipping release binaries from Fedora (N)

Disable the fedora-candidate-compose repo

  • Remove from the manifest.yaml of next-devel the fedora-candidate-compose repo

After Fedora (N) GA

Ship rebased stable

  • Ship stable
  • Set a new update barrier for the final release of N-1 on stable. In the barrier entry set a link to the docs. See discussion

Untag old packages

koji untag N-2 packages from the pool (at some point we'll have GC in place to do this for us, but for now we must remember to do this manually or otherwise distRepo will fail once the signed packages are GC'ed). For example the following snippet finds all RPMs signed by the Fedora 32 key and untags them. Use this process:

  • Find the key short hash. Usually found here. Then:
f32key=12c944d0
key=$f32key
echo > untaglist # create or empty out file
for build in $(koji list-tagged --quiet coreos-pool | cut -f1 -d' '); do
    if koji buildinfo $build | grep $key 1>/dev/null; then
        echo "Adding $build to untag list"
        echo "${build}" >> untaglist
    fi
done

Now we have a list of builds to untag. But we need a few more sanity checks.

  • Make sure none of the builds are used in N based FCOS. Check by running:
f32key=12c944d0
key=$f32key
podman run -it --rm quay.io/fedora/fedora-coreos:testing-devel rpm -qai | grep -B 9 $key
podman rmi quay.io/fedora/fedora-coreos:testing-devel

If there are any RPMs signed by the old key they'll need to be investigated. Maybe they shouldn't be used any longer. Or maybe they're still needed. One example of this is the shim RPM where the same build could be used for many Fedora releases. In this case you'll need to untag the RPM from coreos-pool, run a koji distrepo, which will remove that RPM from the repo metadata, and then re-tag it into the pool. The RPM in the repo will now be signed with a newer signing key.

  • After verifying the list looks good, untag:
# use xargs so we don't exhaust bash string limit
cat untaglist | xargs -L50 koji untag-build -v coreos-pool
  • Now that untagging is done, give a heads up to rpm-ostree developers that N-2 packages have been untagged and that they may need to update their CI compose tests to freeze on a newer FCOS commit.

  • Remove the N-2 signing key from the tag info for the coreos-pool tag. The following commands view the current settings and then update the list to the 33/34/35 keys. You'll most likely have to get someone from releng to run the second command (edit-tag).

    • koji taginfo coreos-pool
    • koji edit-tag coreos-pool -x tag2distrepo.keys="9570ff31 45719a39 9867c58f"

Open ticket for the next Fedora rebase

  • Create a new ticket from the rebase template
    • label with FN label where N is the Fedora version.

Miscellaneous container updates

These are various containers in use throughout our ecosystem. We should update or open a ticket to track updating them once a new Fedora release is out. If you open a ticket instead of doing the update add a link to the ticket as comment.

@travier
Copy link
Member

travier commented Feb 15, 2024

Rawhide version PR: coreos/fedora-coreos-config#2855

@dustymabe
Copy link
Member

I did the koji edit-tag under the At Branching heading because distrepo tasks kicked off by coreos-koji-tagger were failing because there are now RPMs in coreos-pool with the F41 signing key.

koji edit-tag coreos-pool -x tag2distrepo.keys="eb10b464 18B8e74c a15B79cc e99d6ad1"

@marmijo
Copy link
Member

marmijo commented Feb 20, 2024

Update signing keys PR: coreos/coreos-installer#1424

@marmijo
Copy link
Member

marmijo commented Feb 20, 2024

dustymabe added a commit to dustymabe/fedora-coreos-pipeline that referenced this issue Feb 27, 2024
@dustymabe
Copy link
Member

PR to enable next-devel and also set OSBuild to be used: coreos/fedora-coreos-pipeline#967

This is a draft PR because we don't want to merge this yet until we are closer to F40 beta.

@dustymabe dustymabe added the F40 label Mar 14, 2024
aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 15, 2024
aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 18, 2024
aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 18, 2024
@aaradhak
Copy link
Member

dustymabe pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 19, 2024
aaradhak added a commit to coreos/fedora-coreos-config that referenced this issue Mar 19, 2024
dustymabe added a commit to coreos/fedora-coreos-pipeline that referenced this issue Mar 19, 2024
aaradhak added a commit to aaradhak/fedora-coreos-pipeline that referenced this issue Mar 19, 2024
@aaradhak
Copy link
Member

dustymabe pushed a commit to coreos/fedora-coreos-pipeline that referenced this issue Mar 19, 2024
@dustymabe
Copy link
Member

As we have done in the past we will be fast-tracking packages in next-devel/next to ensure no upgrade transition will ever include downgraded packages.

aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 22, 2024
F40 is now in final freeze. This means some packages in F39 will sort
as newer than packages in F39. We'll prevent downgrades by fast-tracking
any packages that would violoate this "no downgrade" rule.

Ref: coreos/fedora-coreos-tracker#1674 (comment)
aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 22, 2024
F40 is now in final freeze. This means some packages in F39 will sort
as newer than packages in F39. We'll prevent downgrades by fast-tracking
any packages that would violoate this "no downgrade" rule.

Ref: coreos/fedora-coreos-tracker#1674 (comment)
dustymabe pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 22, 2024
F40 is now in final freeze. This means some packages in F39 will sort
as newer than packages in F39. We'll prevent downgrades by fast-tracking
any packages that would violoate this "no downgrade" rule.

Ref: coreos/fedora-coreos-tracker#1674 (comment)
dustymabe pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 22, 2024
F40 is now in final freeze. This means some packages in F39 will sort
as newer than packages in F39. We'll prevent downgrades by fast-tracking
any packages that would violoate this "no downgrade" rule.

Ref: coreos/fedora-coreos-tracker#1674 (comment)
dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this issue Mar 22, 2024
F40 is now in final freeze. This means some packages in F39 will sort
as newer than packages in F39. We'll prevent downgrades by fast-tracking
any packages that would violoate this "no downgrade" rule.

Ref: coreos/fedora-coreos-tracker#1674 (comment)
@dustymabe
Copy link
Member

I'm thinking for the beta 40 next release next week we should fast-track the non-rc podman release that came out earlier this week with podman-5.0.0-1.fc40 https://bodhi.fedoraproject.org/updates/FEDORA-2024-a267e93f8c

aaradhak added a commit to aaradhak/fedora-coreos-config that referenced this issue Apr 23, 2024
The Fedora 40 GA is to be released Tuesday April 23rd.

Ref: coreos/fedora-coreos-tracker#1674
aaradhak added a commit to coreos/fedora-coreos-config that referenced this issue Apr 24, 2024
The Fedora 40 GA is to be released Tuesday April 23rd.

Ref: coreos/fedora-coreos-tracker#1674
@dustymabe
Copy link
Member

Testing devel moved over in:

@aaradhak
Copy link
Member

dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this issue Apr 25, 2024
aaradhak pushed a commit to aaradhak/fedora-coreos-pipeline that referenced this issue May 14, 2024
aaradhak added a commit to aaradhak/fedora-coreos-pipeline that referenced this issue May 14, 2024
jlebon added a commit to jlebon/rpm-ostree that referenced this issue Jun 3, 2024
Those packages have been untagged from the pool as per
coreos/fedora-coreos-tracker#1674
@jlebon
Copy link
Member Author

jlebon commented Jun 3, 2024

Removing f38 signing key: https://pagure.io/releng/issue/12145

@jlebon
Copy link
Member Author

jlebon commented Jun 3, 2024

F41 rebase ticket: #1695

@jlebon
Copy link
Member Author

jlebon commented Jun 19, 2024

This is done now.

@jlebon jlebon closed this as completed Jun 19, 2024
marmijo added a commit to marmijo/fedora-coreos-pipeline that referenced this issue Sep 13, 2024
Enabling next-devel for the Fedora 41 release process.

See: coreos/fedora-coreos-tracker#1674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants