-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hitting Tokio panic during encapsulation #3968
Comments
I think this is fallout from #3904 - in the legacy path we're still calling it a native async method, but it isn't anymore and needs to be run from the worker thread. |
Forgot to mention, this was with git main. So something in v2022.12...main. |
Should work to use the new |
Fixes: coreos@60c8fac We changed the method to be non-async (mostly) so it needs to run from the worker thread. There's a bit of the code which does run async using `block_on` and we can only do that from the worker thread. Closes: coreos#3968
It's worth noting how this snuck through CI:
I think this was a one-off; once we pull the trigger on coreos/coreos-assembler#3014 we can pretty quickly delete the old entrypoint and hence the possibility of any bugs like this. |
Hit this while building latest RHCOS locally:
The text was updated successfully, but these errors were encountered: