Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kola test for local dir container deployment #4624

Closed

Conversation

lukewarmtemp
Copy link
Contributor

This change adds a test for deploying FCOS from a container image stored in a local directory. The test is needed for a change in ostree-rs-ext which adds support for the dir transport: ostreedev/ostree-rs-ext#544

In this test, the encapsulate function is used to store the current state of the system to a local directory and is deployed to a temporary sysroot.

@lukewarmtemp lukewarmtemp self-assigned this Sep 25, 2023
This change adds a test for deploying FCOS from a container image stored
in a local directory. The test is needed for a change in ostree-rs-ext
which adds support for the `dir` transport.

In this test, the encapsulate function is used to store the current state
of the system to a local directory and is deployed to a temporary sysroot.
mkdir /var/tmp/sysroot
ostree admin init-fs --modern /var/tmp/sysroot
ostree admin os-init fedora-coreos --sysroot /var/tmp/sysroot
ostree container image deploy --imgref ostree-unverified-image:dir:/var/tmp/fcos --sysroot /var/tmp/sysroot --stateroot fedora-coreos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So...I'm OK having this here, but I think it'd be better to have it in the ostree tests (sorry I should have mentioned this).

Around here https://github.com/ostreedev/ostree-rs-ext/blob/88b5fc7083a97806c79fbdbbe9e06af9e7cad2f5/ci/priv-integration.sh#L107

This would let the test pass right now, without waiting for an -ext release and an update here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure thing, I'll write it on theostree side instead. Should we close this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably close here. One issue is that the way this test works is a bit slow (encapsulating and then immediately unencapsulating again) and it's probably not worth running on every PR here.

@openshift-ci
Copy link

openshift-ci bot commented Sep 25, 2023

@lukewarmtemp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fcos-e2e e878b98 link true /test fcos-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lukewarmtemp
Copy link
Contributor Author

Moved to ostreedev/ostree-rs-ext#547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants