Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup needed! #8

Open
yo96 opened this issue Jul 25, 2019 · 1 comment
Open

Cleanup needed! #8

yo96 opened this issue Jul 25, 2019 · 1 comment

Comments

@yo96
Copy link
Contributor

yo96 commented Jul 25, 2019

Currently our repo is not very clean. We need to do the following:

  • Remove unnecessary comments. Currently there are many useless comments in a number of files, which is ugly. If we do want to keep certain comments, we should explain on top why we do so.
  • Deprecate test vector simulator tests. We still have many tests that are using test vector simulator and these tests are not very readable and very difficult to maintain (especially those tests for the network). We should use ad-hoc test as our simple directed test.
  • Reuse CL tests. Our RTL models should just reuse the test cases for their CL equivalence (if there is one). Now most RTL and CL tests are separate.
  • Use f-string for line trace. Now that we are in python3, there is no reason why we don't use f-string.
@yo96
Copy link
Contributor Author

yo96 commented Jul 25, 2019

We should also apply format tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yo96