From f9cc3f3bcb033c5b2dee614e72b22869e0b1ed4f Mon Sep 17 00:00:00 2001 From: rgu0114 Date: Fri, 19 Apr 2024 11:37:32 -0400 Subject: [PATCH 1/5] node 18 upgrades without using openssl legacy provider for test script --- .github/workflows/cd.yml | 2 +- .github/workflows/ci.yml | 2 +- .nvmrc | 2 +- functions/package.json | 2 +- package.json | 4 ++-- yarn.lock | 9 ++++++++- 6 files changed, 14 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index 2323d72d2..a3f6ed013 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -12,7 +12,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: "^16.20.2" + node-version: "^18.20.0" - name: Install run: yarn install - name: Build Client diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 21ed31b95..7d0c13bf4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: "^16.20.2" + node-version: "^18.20.0" - name: Install run: | yarn install diff --git a/.nvmrc b/.nvmrc index 2ab3d4be5..91f7588a1 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v16.20.2 +v18.20.0 diff --git a/functions/package.json b/functions/package.json index 7b18bd96b..1016a726a 100644 --- a/functions/package.json +++ b/functions/package.json @@ -12,7 +12,7 @@ "logs": "firebase functions:log" }, "engines": { - "node": "16" + "node": "^18.20.0" }, "main": "lib/index.js", "dependencies": { diff --git a/package.json b/package.json index c1e88cb94..8e0350958 100644 --- a/package.json +++ b/package.json @@ -59,10 +59,10 @@ "yarn": "^1.22.17" }, "scripts": { - "build": "react-scripts build", + "build": "NODE_OPTIONS=--openssl-legacy-provider react-scripts build", "build:staging": "REACT_APP_IS_STAGING=true react-scripts build", "deploy": "firebase deploy", - "start": "react-scripts start", + "start": "NODE_OPTIONS=--openssl-legacy-provider react-scripts start", "s": "yarn start", "test": "NODE_ENV=test firebase emulators:exec --only firestore \"./test.sh\"", "lint": "eslint . --ext tsx --ext ts", diff --git a/yarn.lock b/yarn.lock index 1f1493be2..233df3093 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6500,7 +6500,7 @@ debug@^3.1.0, debug@^3.1.1, debug@^3.2.5, debug@^3.2.7: dependencies: ms "^2.1.1" -debug@^4.3.1, debug@^4.3.4: +debug@^4.3.1: version "4.3.4" resolved "https://registry.yarnpkg.com/debug/-/debug-4.3.4.tgz#1319f6579357f2338d3337d2cdd4914bb5dcc865" integrity sha512-PRWFHuSU3eDtQJPvnNY7Jcket1j0t5OuOsFzPPzsekD52Zl8qUfFIPEiswXqIvHWGVHOgX+7G/vCNNhehwxfkQ== @@ -15674,6 +15674,13 @@ semver@^7.3.2: dependencies: lru-cache "^6.0.0" +semver@^7.3.5: + version "7.6.0" + resolved "https://registry.yarnpkg.com/semver/-/semver-7.6.0.tgz#1a46a4db4bffcccd97b743b5005c8325f23d4e2d" + integrity sha512-EnwXhrlwXMk9gKu5/flx5sv/an57AkRplG3hTK68W7FRDN+k+OWBj65M7719OkA82XLBxrcX0KSHj+X5COhOVg== + dependencies: + lru-cache "^6.0.0" + send@0.17.1: version "0.17.1" resolved "https://registry.yarnpkg.com/send/-/send-0.17.1.tgz#c1d8b059f7900f7466dd4938bdc44e11ddb376c8" From 54390d472fc5cd67caf6e22f2bfc35eed0d254b7 Mon Sep 17 00:00:00 2001 From: rgu0114 Date: Fri, 19 Apr 2024 11:47:10 -0400 Subject: [PATCH 2/5] keep firebase functions engine on 16.20.2 (for now) --- functions/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/functions/package.json b/functions/package.json index 1016a726a..c5a8db0fb 100644 --- a/functions/package.json +++ b/functions/package.json @@ -12,7 +12,7 @@ "logs": "firebase functions:log" }, "engines": { - "node": "^18.20.0" + "node": "^16.20.2" }, "main": "lib/index.js", "dependencies": { From b2e6d066c88519a9d0ccd89254e0ba68bbeeef8d Mon Sep 17 00:00:00 2001 From: rgu0114 Date: Fri, 19 Apr 2024 11:50:30 -0400 Subject: [PATCH 3/5] revert ci/cd node versions instead --- .github/workflows/cd.yml | 2 +- .github/workflows/ci.yml | 2 +- functions/package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index a3f6ed013..2323d72d2 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -12,7 +12,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: "^18.20.0" + node-version: "^16.20.2" - name: Install run: yarn install - name: Build Client diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7d0c13bf4..21ed31b95 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: "^18.20.0" + node-version: "^16.20.2" - name: Install run: | yarn install diff --git a/functions/package.json b/functions/package.json index c5a8db0fb..1016a726a 100644 --- a/functions/package.json +++ b/functions/package.json @@ -12,7 +12,7 @@ "logs": "firebase functions:log" }, "engines": { - "node": "^16.20.2" + "node": "^18.20.0" }, "main": "lib/index.js", "dependencies": { From f3ee06b3154d986e3bbaacb397c6571a140f082e Mon Sep 17 00:00:00 2001 From: rgu0114 Date: Fri, 19 Apr 2024 11:52:30 -0400 Subject: [PATCH 4/5] =?UTF-8?q?that=20wasn't=20it=20=E2=80=93=20revert?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/cd.yml | 2 +- .github/workflows/ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index 2323d72d2..a3f6ed013 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -12,7 +12,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: "^16.20.2" + node-version: "^18.20.0" - name: Install run: yarn install - name: Build Client diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 21ed31b95..7d0c13bf4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: "^16.20.2" + node-version: "^18.20.0" - name: Install run: | yarn install From e869e234c001da3a6723aeee8c7058766da72709 Mon Sep 17 00:00:00 2001 From: rgu0114 Date: Wed, 24 Apr 2024 17:06:03 -0400 Subject: [PATCH 5/5] Merge branch 'master' into upgrade-node-v18-retry --- yarn.lock | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/yarn.lock b/yarn.lock index 233df3093..81ae9f675 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2,6 +2,16 @@ # yarn lockfile v1 +"@apidevtools/json-schema-ref-parser@^9.0.3": + version "9.1.2" + resolved "https://registry.yarnpkg.com/@apidevtools/json-schema-ref-parser/-/json-schema-ref-parser-9.1.2.tgz#8ff5386b365d4c9faa7c8b566ff16a46a577d9b8" + integrity sha512-r1w81DpR+KyRWd3f+rk6TNqMgedmAxZP5v5KWlXQWlgMUUtyEJch0DKEci1SorPMiSeM8XPl7MZ3miJ60JIpQg== + dependencies: + "@jsdevtools/ono" "^7.1.3" + "@types/json-schema" "^7.0.6" + call-me-maybe "^1.0.1" + js-yaml "^4.1.0" + "@apidevtools/json-schema-ref-parser@^9.0.3": version "9.1.2" resolved "https://registry.yarnpkg.com/@apidevtools/json-schema-ref-parser/-/json-schema-ref-parser-9.1.2.tgz#8ff5386b365d4c9faa7c8b566ff16a46a577d9b8" @@ -6500,7 +6510,7 @@ debug@^3.1.0, debug@^3.1.1, debug@^3.2.5, debug@^3.2.7: dependencies: ms "^2.1.1" -debug@^4.3.1: +debug@^4.3.1, debug@^4.3.4: version "4.3.4" resolved "https://registry.yarnpkg.com/debug/-/debug-4.3.4.tgz#1319f6579357f2338d3337d2cdd4914bb5dcc865" integrity sha512-PRWFHuSU3eDtQJPvnNY7Jcket1j0t5OuOsFzPPzsekD52Zl8qUfFIPEiswXqIvHWGVHOgX+7G/vCNNhehwxfkQ==