From b816285a706acbf3efa8a946f834ca32e093ff41 Mon Sep 17 00:00:00 2001 From: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> Date: Sat, 23 Nov 2024 14:19:24 +0100 Subject: [PATCH] CI: Stop caching the msvc build dir This breaks when the msvc version in the runner image gets updated. If we could figure out the location / version of the selected msvc toolchain, we could add the toolchain to the cache key. --- .github/workflows/visual_studio.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/visual_studio.yaml b/.github/workflows/visual_studio.yaml index 9c9d6c78..4a8b14b5 100644 --- a/.github/workflows/visual_studio.yaml +++ b/.github/workflows/visual_studio.yaml @@ -40,12 +40,12 @@ jobs: # The initial configure for MSVC is quite slow, so we cache the build directory # (including the build directories of the tests) since reconfiguring is # significantly faster. - - name: Cache MSVC build directory - id: cache-msvc-builddir - uses: actions/cache@v4 - with: - path: build - key: ${{ inputs.os }}-${{ inputs.target_arch }}-${{ inputs.rust }}-msvc-${{ inputs.vs_version}}-build + # - name: Cache MSVC build directory + # id: cache-msvc-builddir + # uses: actions/cache@v4 + # with: + # path: build + # key: ${{ inputs.os }}-${{ inputs.target_arch }}-${{ inputs.rust }}-msvc-${{ inputs.vs_version}}-build - name: Configure run: cmake -S. -Bbuild -DCORROSION_TESTS_KEEP_BUILDDIRS=ON "-DRust_TOOLCHAIN=${{steps.install_rust.outputs.name}}" --preset "vs-${{ inputs.vs_version }}-${{ inputs.target_arch }}" - name: Run Tests