From d995ae7de51dacb90c04f98ab8e7e43472062563 Mon Sep 17 00:00:00 2001 From: Chan-Ho Suh Date: Thu, 14 Apr 2022 18:38:35 -0400 Subject: [PATCH 1/6] Add slither action --- .github/workflows/CI.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 814e4bb..19e04aa 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -60,3 +60,9 @@ jobs: ALCHEMY_API_KEY: ${{ secrets.ALCHEMY_API_KEY }} - name: Check for dot-only run: yarn dot-only + + analyze: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: crytic/slither-action@v0.1.1 From 52ed30a86d6cb5915649f19a15655d387ac8f81d Mon Sep 17 00:00:00 2001 From: Chan-Ho Suh Date: Thu, 14 Apr 2022 18:45:20 -0400 Subject: [PATCH 2/6] Fix Node version --- .github/workflows/CI.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 19e04aa..368f743 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -63,6 +63,10 @@ jobs: analyze: runs-on: ubuntu-latest + - name: Use Node.js 14.x + uses: actions/setup-node@v1 + with: + node-version: 14.x steps: - uses: actions/checkout@v2 - uses: crytic/slither-action@v0.1.1 From 4d296ee5f4da1978a194488d0a7fe38971a57b2f Mon Sep 17 00:00:00 2001 From: Chan-Ho Suh Date: Thu, 14 Apr 2022 18:47:08 -0400 Subject: [PATCH 3/6] Fix yaml syntax --- .github/workflows/CI.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 368f743..a88cc1d 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -63,10 +63,10 @@ jobs: analyze: runs-on: ubuntu-latest + steps: - name: Use Node.js 14.x uses: actions/setup-node@v1 with: node-version: 14.x - steps: - - uses: actions/checkout@v2 - - uses: crytic/slither-action@v0.1.1 + - uses: actions/checkout@v2 + - uses: crytic/slither-action@v0.1.1 From 99d8ea073c120debc24697ecd5a40967e04be7dd Mon Sep 17 00:00:00 2001 From: Chan-Ho Suh Date: Thu, 14 Apr 2022 18:54:53 -0400 Subject: [PATCH 4/6] Add slither as step in existing workflow --- .github/workflows/CI.yml | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index a88cc1d..baba90a 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -60,13 +60,6 @@ jobs: ALCHEMY_API_KEY: ${{ secrets.ALCHEMY_API_KEY }} - name: Check for dot-only run: yarn dot-only + - name: Slither static analysis + uses: crytic/slither-action@v0.1.1 - analyze: - runs-on: ubuntu-latest - steps: - - name: Use Node.js 14.x - uses: actions/setup-node@v1 - with: - node-version: 14.x - - uses: actions/checkout@v2 - - uses: crytic/slither-action@v0.1.1 From b497ccf333c10376f3c7484a47c320aa5654a521 Mon Sep 17 00:00:00 2001 From: Chan-Ho Suh Date: Thu, 14 Apr 2022 18:58:21 -0400 Subject: [PATCH 5/6] Specify node version for slither --- .github/workflows/CI.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index baba90a..73fe4af 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -62,4 +62,6 @@ jobs: run: yarn dot-only - name: Slither static analysis uses: crytic/slither-action@v0.1.1 + with: + node-version: ${{ matrix.node-version }} From 6a98a2c79456089ccce12d3cf7db280088e029a8 Mon Sep 17 00:00:00 2001 From: Chan-Ho Suh Date: Thu, 14 Apr 2022 19:03:05 -0400 Subject: [PATCH 6/6] Hardcode version for now --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 73fe4af..4e8fb79 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -63,5 +63,5 @@ jobs: - name: Slither static analysis uses: crytic/slither-action@v0.1.1 with: - node-version: ${{ matrix.node-version }} + node-version: 14.19.1