Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check routes before authorization #14

Open
dogukanteber opened this issue Apr 19, 2023 · 0 comments
Open

Check routes before authorization #14

dogukanteber opened this issue Apr 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@dogukanteber
Copy link
Collaborator

Currently, when a request comes in, we first look at its authorization header. If the header is valid and the creds are correct, we then look at the requested route. If the header is not valid, we return 401 Unauthorized status code. But we should first check whether the route is valid and then check the credentials.

For instance, running

curl -v localhost:8080/not/valid/route

returns 401 but it should return 404.

@dogukanteber dogukanteber added the bug Something isn't working label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant